diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-06-21 15:02:24 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-21 15:02:24 +0000 |
commit | 9c292fef316739f43730f11b9a2b6d3e4b725b54 (patch) | |
tree | e286b6c7a36c50eba235c7b69b30b95fc36cb906 /core/fpdfapi/parser/cpdf_object_walker.cpp | |
parent | bcd66f54de1291ddf8b7b7caca3e7360e14fcc8d (diff) | |
download | pdfium-9c292fef316739f43730f11b9a2b6d3e4b725b54.tar.xz |
Avoid const-refs to implicitly constructed strings.
Because the invisible temporary goes out of scope at the next
semicolon.
Also avoid returning const string references since the cost is
low to properly keep the string alive.
Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a
Reviewed-on: https://pdfium-review.googlesource.com/35710
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/cpdf_object_walker.cpp')
-rw-r--r-- | core/fpdfapi/parser/cpdf_object_walker.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fpdfapi/parser/cpdf_object_walker.cpp b/core/fpdfapi/parser/cpdf_object_walker.cpp index cb59a05d06..3aaa25e9f7 100644 --- a/core/fpdfapi/parser/cpdf_object_walker.cpp +++ b/core/fpdfapi/parser/cpdf_object_walker.cpp @@ -57,7 +57,7 @@ class DictionaryIterator : public CPDF_ObjectWalker::SubobjectIterator { dict_iterator_ = object()->GetDict()->begin(); } - const ByteString& dict_key() const { return dict_key_; } + ByteString dict_key() const { return dict_key_; } private: CPDF_Dictionary::const_iterator dict_iterator_; |