diff options
| author | tsepez <tsepez@chromium.org> | 2016-11-09 13:28:26 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-09 13:28:26 -0800 |
| commit | 335cf093231c984a23cb9ea113148ea1f19621ba (patch) | |
| tree | e9c7803b0ce71269beb3d423549a2d6a0ac7784a /core/fpdfapi/parser/cpdf_reference.cpp | |
| parent | 3ff4deea307c38462393e4f83dabe32949338168 (diff) | |
| download | pdfium-335cf093231c984a23cb9ea113148ea1f19621ba.tar.xz | |
Return unique_ptr from CPDF_Object::Clone().
Because that's what clone does. There are numerous
release() calls that will go away as more code is
converted.
Review-Url: https://codereview.chromium.org/2484033002
Diffstat (limited to 'core/fpdfapi/parser/cpdf_reference.cpp')
| -rw-r--r-- | core/fpdfapi/parser/cpdf_reference.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/core/fpdfapi/parser/cpdf_reference.cpp b/core/fpdfapi/parser/cpdf_reference.cpp index a9cdf54855..8f44aa0200 100644 --- a/core/fpdfapi/parser/cpdf_reference.cpp +++ b/core/fpdfapi/parser/cpdf_reference.cpp @@ -7,6 +7,7 @@ #include "core/fpdfapi/parser/cpdf_reference.h" #include "core/fpdfapi/parser/cpdf_indirect_object_holder.h" +#include "third_party/base/ptr_util.h" #include "third_party/base/stl_util.h" CPDF_Reference::CPDF_Reference(CPDF_IndirectObjectHolder* pDoc, int objnum) @@ -50,11 +51,11 @@ const CPDF_Reference* CPDF_Reference::AsReference() const { return this; } -CPDF_Object* CPDF_Reference::Clone() const { +std::unique_ptr<CPDF_Object> CPDF_Reference::Clone() const { return CloneObjectNonCyclic(false); } -CPDF_Object* CPDF_Reference::CloneNonCyclic( +std::unique_ptr<CPDF_Object> CPDF_Reference::CloneNonCyclic( bool bDirect, std::set<const CPDF_Object*>* pVisited) const { pVisited->insert(this); @@ -64,7 +65,7 @@ CPDF_Object* CPDF_Reference::CloneNonCyclic( ? pDirect->CloneNonCyclic(true, pVisited) : nullptr; } - return new CPDF_Reference(m_pObjList, m_RefObjNum); + return pdfium::MakeUnique<CPDF_Reference>(m_pObjList, m_RefObjNum); } CPDF_Object* CPDF_Reference::SafeGetDirect() const { |