diff options
author | Lei Zhang <thestig@chromium.org> | 2017-11-02 19:27:08 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-02 19:27:08 +0000 |
commit | a6adac83c6aadbacf2a338d2e55148f7d3417762 (patch) | |
tree | 2a2199d74d18545d2fffd7bad3c44478b6560dce /core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp | |
parent | 23efbbd8a1840d5dd746d94069741b0532b61b14 (diff) | |
download | pdfium-a6adac83c6aadbacf2a338d2e55148f7d3417762.tar.xz |
Remove some C-style const char* casts.
Change-Id: I4785dd277b9da072ee3c55e2aaeb688bbf02852e
Reviewed-on: https://pdfium-review.googlesource.com/17391
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp')
-rw-r--r-- | core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp b/core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp index a2f43386e7..e8d3b7142a 100644 --- a/core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp +++ b/core/fpdfapi/parser/cpdf_simple_parser_unittest.cpp @@ -11,7 +11,7 @@ #include "testing/test_support.h" TEST(SimpleParserTest, GetWord) { - pdfium::StrFuncTestData test_data[] = { + static const pdfium::StrFuncTestData test_data[] = { // Empty src string. STR_IN_OUT_CASE("", ""), // Content with whitespaces only. @@ -51,15 +51,17 @@ TEST(SimpleParserTest, GetWord) { const pdfium::StrFuncTestData& data = test_data[i]; CPDF_SimpleParser parser(data.input, data.input_size); ByteStringView word = parser.GetWord(); - EXPECT_EQ(std::string(reinterpret_cast<const char*>(data.expected), - data.expected_size), - std::string(word.unterminated_c_str(), word.GetLength())) + EXPECT_EQ(data.expected_size, word.GetLength()) << " for case " << i; + if (data.expected_size != word.GetLength()) + continue; + EXPECT_EQ( + 0, memcmp(data.expected, word.unterminated_c_str(), data.expected_size)) << " for case " << i; } } TEST(SimpleParserTest, FindTagParamFromStart) { - struct FindTagTestStruct { + static const struct FindTagTestStruct { const unsigned char* input; unsigned int input_size; const char* token; |