summaryrefslogtreecommitdiff
path: root/core/fpdfapi/parser/cpdf_stream_acc.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-06-21 15:02:24 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-21 15:02:24 +0000
commit9c292fef316739f43730f11b9a2b6d3e4b725b54 (patch)
treee286b6c7a36c50eba235c7b69b30b95fc36cb906 /core/fpdfapi/parser/cpdf_stream_acc.h
parentbcd66f54de1291ddf8b7b7caca3e7360e14fcc8d (diff)
downloadpdfium-9c292fef316739f43730f11b9a2b6d3e4b725b54.tar.xz
Avoid const-refs to implicitly constructed strings.
Because the invisible temporary goes out of scope at the next semicolon. Also avoid returning const string references since the cost is low to properly keep the string alive. Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a Reviewed-on: https://pdfium-review.googlesource.com/35710 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/cpdf_stream_acc.h')
-rw-r--r--core/fpdfapi/parser/cpdf_stream_acc.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fpdfapi/parser/cpdf_stream_acc.h b/core/fpdfapi/parser/cpdf_stream_acc.h
index cd836340fd..00bd353fcb 100644
--- a/core/fpdfapi/parser/cpdf_stream_acc.h
+++ b/core/fpdfapi/parser/cpdf_stream_acc.h
@@ -36,7 +36,7 @@ class CPDF_StreamAcc : public Retainable {
pdfium::span<uint8_t> GetSpan() const {
return pdfium::make_span(GetData(), GetSize());
}
- const ByteString& GetImageDecoder() const { return m_ImageDecoder; }
+ ByteString GetImageDecoder() const { return m_ImageDecoder; }
const CPDF_Dictionary* GetImageParam() const { return m_pImageParam; }
std::unique_ptr<uint8_t, FxFreeDeleter> DetachData();