diff options
author | Nicolas Pena <npm@chromium.org> | 2017-06-20 17:42:39 -0400 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-06-20 22:10:32 +0000 |
commit | 995a601c50874729ac40e2cc444b8894cf2aea96 (patch) | |
tree | f2429607324df0be7585c2099505444e0247ef1f /core/fpdfapi/parser/fpdf_parser_decode.h | |
parent | dce2d72f9fbc166ee8eed0e362ab26e1e1a33cdd (diff) | |
download | pdfium-995a601c50874729ac40e2cc444b8894cf2aea96.tar.xz |
Cleanup fpdf_parser_decode
This CL fixes some nits in fpdf_parser_decode, especially avoiding non-const
reference parameters.
Change-Id: Ibb914850afd924bb398f886ac862f7589519ef7e
Reviewed-on: https://pdfium-review.googlesource.com/6750
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/fpdf_parser_decode.h')
-rw-r--r-- | core/fpdfapi/parser/fpdf_parser_decode.h | 41 |
1 files changed, 21 insertions, 20 deletions
diff --git a/core/fpdfapi/parser/fpdf_parser_decode.h b/core/fpdfapi/parser/fpdf_parser_decode.h index 955a8cfb32..4d2c6732e0 100644 --- a/core/fpdfapi/parser/fpdf_parser_decode.h +++ b/core/fpdfapi/parser/fpdf_parser_decode.h @@ -20,10 +20,10 @@ extern const uint16_t PDFDocEncoding[256]; CFX_ByteString PDF_NameDecode(const CFX_ByteStringC& orig); CFX_ByteString PDF_NameDecode(const CFX_ByteString& orig); CFX_ByteString PDF_NameEncode(const CFX_ByteString& orig); -CFX_ByteString PDF_EncodeString(const CFX_ByteString& src, bool bHex = false); +CFX_ByteString PDF_EncodeString(const CFX_ByteString& src, bool bHex); CFX_WideString PDF_DecodeText(const uint8_t* pData, uint32_t size); CFX_WideString PDF_DecodeText(const CFX_ByteString& bstr); -CFX_ByteString PDF_EncodeText(const wchar_t* pString, int len = -1); +CFX_ByteString PDF_EncodeText(const wchar_t* pString, int len); CFX_ByteString PDF_EncodeText(const CFX_WideString& str); bool FlateEncode(const uint8_t* src_buf, @@ -41,12 +41,13 @@ bool PngEncode(const uint8_t* src_buf, uint32_t FlateDecode(const uint8_t* src_buf, uint32_t src_size, - uint8_t*& dest_buf, - uint32_t& dest_size); + uint8_t** dest_buf, + uint32_t* dest_size); + uint32_t RunLengthDecode(const uint8_t* src_buf, uint32_t src_size, - uint8_t*& dest_buf, - uint32_t& dest_size); + uint8_t** dest_buf, + uint32_t* dest_size); std::unique_ptr<CCodec_ScanlineDecoder> FPDFAPI_CreateFaxDecoder( const uint8_t* src_buf, @@ -64,32 +65,32 @@ std::unique_ptr<CCodec_ScanlineDecoder> FPDFAPI_CreateFlateDecoder( int bpc, const CPDF_Dictionary* pParams); -// Public for testing. uint32_t A85Decode(const uint8_t* src_buf, uint32_t src_size, - uint8_t*& dest_buf, - uint32_t& dest_size); -// Public for testing. + uint8_t** dest_buf, + uint32_t* dest_size); + uint32_t HexDecode(const uint8_t* src_buf, uint32_t src_size, - uint8_t*& dest_buf, - uint32_t& dest_size); -// Public for testing. + uint8_t** dest_buf, + uint32_t* dest_size); + uint32_t FPDFAPI_FlateOrLZWDecode(bool bLZW, const uint8_t* src_buf, uint32_t src_size, CPDF_Dictionary* pParams, uint32_t estimated_size, - uint8_t*& dest_buf, - uint32_t& dest_size); + uint8_t** dest_buf, + uint32_t* dest_size); + bool PDF_DataDecode(const uint8_t* src_buf, uint32_t src_size, const CPDF_Dictionary* pDict, - uint8_t*& dest_buf, - uint32_t& dest_size, - CFX_ByteString* ImageEncoding, - CPDF_Dictionary*& pImageParms, uint32_t estimated_size, - bool bImageAcc); + bool bImageAcc, + uint8_t** dest_buf, + uint32_t* dest_size, + CFX_ByteString* ImageEncoding, + CPDF_Dictionary** pImageParms); #endif // CORE_FPDFAPI_PARSER_FPDF_PARSER_DECODE_H_ |