diff options
author | Lei Zhang <thestig@chromium.org> | 2018-09-11 07:59:18 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-09-11 07:59:18 +0000 |
commit | bb06ae5ad0b6389490befc6831517ab383e94031 (patch) | |
tree | 97e9e2367db537f6a4f459481d77103973450b3c /core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp | |
parent | c2f404f993f13d303f9e47d2f97aff727becac7d (diff) | |
download | pdfium-bb06ae5ad0b6389490befc6831517ab383e94031.tar.xz |
Make flate decode functions' buffer out parameter unique_ptrs.
Change-Id: Idb14846e87a8287dd911b0a2f7a32146e86c2af7
Reviewed-on: https://pdfium-review.googlesource.com/41853
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp')
-rw-r--r-- | core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp b/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp index d7256f0da5..94776e17ea 100644 --- a/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp +++ b/core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp @@ -74,7 +74,7 @@ TEST_F(FPDFParserDecodeEmbeddertest, FlateDecode) { for (size_t i = 0; i < FX_ArraySize(flate_decode_cases); ++i) { const pdfium::DecodeTestData& data = flate_decode_cases[i]; - unsigned char* buf = nullptr; + std::unique_ptr<uint8_t, FxFreeDeleter> buf; uint32_t buf_size; EXPECT_EQ(data.processed_size, FlateDecode({data.input, data.input_size}, &buf, &buf_size)) @@ -83,9 +83,8 @@ TEST_F(FPDFParserDecodeEmbeddertest, FlateDecode) { EXPECT_EQ(data.expected_size, buf_size) << " for case " << i; if (data.expected_size != buf_size) continue; - EXPECT_EQ(0, memcmp(data.expected, buf, data.expected_size)) + EXPECT_EQ(0, memcmp(data.expected, buf.get(), data.expected_size)) << " for case " << i; - FX_Free(buf); } } |