Make friend RetainPtr<T> statements consistently public.

Also make destructors private for RetainPtr sub-classes, and add missing
destructors.

Change-Id: I451bf0aae2dae943b1f450d0aa4ca5124dc578fd
Reviewed-on: https://pdfium-review.googlesource.com/32853
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

1 files changed, 3 insertions, 4 deletions

diff --git a/core/fpdfapi/render/cpdf_dibsource.h b/core/fpdfapi/render/cpdf_dibsource.h
index 4646bf2fe9..50d9c6ef9c 100644
--- a/core/fpdfapi/render/cpdf_dibsource.h
+++ b/core/fpdfapi/render/cpdf_dibsource.h
@@ -41,12 +41,10 @@ struct DIB_COMP_DATA {
 
 class CPDF_DIBSource : public CFX_DIBSource {
  public:
-  template <typename T, typename... Args>
-  friend RetainPtr<T> pdfium::MakeRetain(Args&&... args);
-
   enum class LoadState : uint8_t { kFail, kSuccess, kContinue };
 
-  ~CPDF_DIBSource() override;
+  template <typename T, typename... Args>
+  friend RetainPtr<T> pdfium::MakeRetain(Args&&... args);
 
   bool Load(CPDF_Document* pDoc, const CPDF_Stream* pStream);
 
@@ -80,6 +78,7 @@ class CPDF_DIBSource : public CFX_DIBSource {
 
  private:
   CPDF_DIBSource();
+  ~CPDF_DIBSource() override;
 
   LoadState StartLoadMask();
   LoadState StartLoadMaskDIB();