diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-03-27 13:51:46 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-03-28 14:14:50 +0000 |
| commit | 0004f29bf6ee3c6060a272c79f14993e92e053c7 (patch) | |
| tree | b82385e4853a157e10148af8d95ebb6bae4fb4c7 /core/fpdfapi/render/cpdf_dibsource.h | |
| parent | 369fe1f7f9f3a424ee3cf8f992c3128db27fa479 (diff) | |
| download | pdfium-0004f29bf6ee3c6060a272c79f14993e92e053c7.tar.xz | |
Refcount all CFX_DIBSources (and subclasses) all the time.
There are currently several ownership models for these objects,
including ad-hoc logic for sharing and deletion, and the
now-redundant CFX_DIBitmapRef externally-counted handle to the DIBs.
Replace them all with the internal refcount scheme.
Change-Id: I2db399dfc19219eda384f94cc989353b78ce2872
Reviewed-on: https://pdfium-review.googlesource.com/3166
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/render/cpdf_dibsource.h')
| -rw-r--r-- | core/fpdfapi/render/cpdf_dibsource.h | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/core/fpdfapi/render/cpdf_dibsource.h b/core/fpdfapi/render/cpdf_dibsource.h index b0f8dedaf7..c77aac1776 100644 --- a/core/fpdfapi/render/cpdf_dibsource.h +++ b/core/fpdfapi/render/cpdf_dibsource.h @@ -39,7 +39,9 @@ typedef struct { class CPDF_DIBSource : public CFX_DIBSource { public: - CPDF_DIBSource(); + template <typename T, typename... Args> + friend CFX_RetainPtr<T> pdfium::MakeRetain(Args&&... args); + ~CPDF_DIBSource() override; bool Load(CPDF_Document* pDoc, const CPDF_Stream* pStream); @@ -71,9 +73,11 @@ class CPDF_DIBSource : public CFX_DIBSource { int StartLoadMaskDIB(); int ContinueLoadMaskDIB(IFX_Pause* pPause); int ContinueToLoadMask(); - CPDF_DIBSource* DetachMask(); + CFX_RetainPtr<CPDF_DIBSource> DetachMask(); private: + CPDF_DIBSource(); + bool LoadColorInfo(const CPDF_Dictionary* pFormResources, const CPDF_Dictionary* pPageResources); DIB_COMP_DATA* GetDecodeAndMaskArray(bool* bDefaultDecode, bool* bColorKey); @@ -133,9 +137,9 @@ class CPDF_DIBSource : public CFX_DIBSource { DIB_COMP_DATA* m_pCompData; uint8_t* m_pLineBuf; uint8_t* m_pMaskedLine; - std::unique_ptr<CFX_DIBitmap> m_pCachedBitmap; + CFX_RetainPtr<CFX_DIBitmap> m_pCachedBitmap; + CFX_RetainPtr<CPDF_DIBSource> m_pMask; std::unique_ptr<CCodec_ScanlineDecoder> m_pDecoder; - CPDF_DIBSource* m_pMask; std::unique_ptr<CPDF_StreamAcc> m_pGlobalStream; std::unique_ptr<CCodec_Jbig2Context> m_pJbig2Context; CPDF_Stream* m_pMaskStream; |