diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-21 15:02:24 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-21 15:02:24 +0000 |
| commit | 9c292fef316739f43730f11b9a2b6d3e4b725b54 (patch) | |
| tree | e286b6c7a36c50eba235c7b69b30b95fc36cb906 /core/fpdfapi/render | |
| parent | bcd66f54de1291ddf8b7b7caca3e7360e14fcc8d (diff) | |
| download | pdfium-9c292fef316739f43730f11b9a2b6d3e4b725b54.tar.xz | |
Avoid const-refs to implicitly constructed strings.
Because the invisible temporary goes out of scope at the next
semicolon.
Also avoid returning const string references since the cost is
low to properly keep the string alive.
Change-Id: Id283e4fd99f79a02d79d739a533a4ce05e831e2a
Reviewed-on: https://pdfium-review.googlesource.com/35710
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi/render')
| -rw-r--r-- | core/fpdfapi/render/cpdf_dibsource.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/core/fpdfapi/render/cpdf_dibsource.cpp b/core/fpdfapi/render/cpdf_dibsource.cpp index 98a2dda999..72dec67438 100644 --- a/core/fpdfapi/render/cpdf_dibsource.cpp +++ b/core/fpdfapi/render/cpdf_dibsource.cpp @@ -288,8 +288,7 @@ CPDF_DIBSource::LoadState CPDF_DIBSource::ContinueLoadDIBSource( if (m_Status == LoadState::kFail) return LoadState::kFail; - const ByteString& decoder = m_pStreamAcc->GetImageDecoder(); - if (decoder == "JPXDecode") + if (m_pStreamAcc->GetImageDecoder() == "JPXDecode") return LoadState::kFail; FXCODEC_STATUS iDecodeStatus; @@ -448,7 +447,7 @@ bool CPDF_DIBSource::GetDecodeAndMaskArray(bool* bDefaultDecode, } CPDF_DIBSource::LoadState CPDF_DIBSource::CreateDecoder() { - const ByteString& decoder = m_pStreamAcc->GetImageDecoder(); + ByteString decoder = m_pStreamAcc->GetImageDecoder(); if (decoder.IsEmpty()) return LoadState::kSuccess; |