summaryrefslogtreecommitdiff
path: root/core/fpdfapi
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-10-05 12:41:21 -0700
committerCommit bot <commit-bot@chromium.org>2016-10-05 12:41:21 -0700
commit87a8d4c605ec1c43ccd092b57e1aadf1dfe595de (patch)
treec730df68c5b8dc20e24874f38aefe3fbaee95bcb /core/fpdfapi
parent8afe15a019c78a24168ebc42306342c25358ccdf (diff)
downloadpdfium-87a8d4c605ec1c43ccd092b57e1aadf1dfe595de.tar.xz
Rework a redundant check when calling ConvertToIndirectObjectAt()
This avoids a re-assignment that can otherwise cause a later fault. BUG=pdfium:607 Review-Url: https://codereview.chromium.org/2393953002
Diffstat (limited to 'core/fpdfapi')
-rw-r--r--core/fpdfapi/parser/cpdf_array.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fpdfapi/parser/cpdf_array.cpp b/core/fpdfapi/parser/cpdf_array.cpp
index e9a92eeae6..9a2dba0161 100644
--- a/core/fpdfapi/parser/cpdf_array.cpp
+++ b/core/fpdfapi/parser/cpdf_array.cpp
@@ -152,7 +152,7 @@ void CPDF_Array::ConvertToIndirectObjectAt(size_t i,
return;
CPDF_Object* pObj = m_Objects[i];
- if (!pObj || pObj->GetObjNum() != 0)
+ if (!pObj || pObj->IsReference())
return;
uint32_t dwObjNum = pHolder->AddIndirectObject(pObj);