summaryrefslogtreecommitdiff
path: root/core/fpdfapi
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-04-11 18:09:30 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-04-11 18:09:30 +0000
commit5b1fd5c7f172e32aed4fc47bf57a17c63c13e03c (patch)
treec122c87c625e007c5cfc43bf3624475c5bc4e558 /core/fpdfapi
parent7b77dfc9aafb423e6204dd5433699cfd787147b3 (diff)
downloadpdfium-5b1fd5c7f172e32aed4fc47bf57a17c63c13e03c.tar.xz
Fix trailing whitespace handling in CPDF_StreamParser::ReadInlineStream()
After advancing past whitespace, the buffer may become empty. We were checking too early. Bug: 831498 Test: covered by fuzzers Change-Id: I6796b4723a05c2bcafe495dc7bc648213aa9cc22 Reviewed-on: https://pdfium-review.googlesource.com/30191 Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfapi')
-rw-r--r--core/fpdfapi/page/cpdf_streamparser.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/core/fpdfapi/page/cpdf_streamparser.cpp b/core/fpdfapi/page/cpdf_streamparser.cpp
index c6660b799b..82f31dd007 100644
--- a/core/fpdfapi/page/cpdf_streamparser.cpp
+++ b/core/fpdfapi/page/cpdf_streamparser.cpp
@@ -114,12 +114,12 @@ std::unique_ptr<CPDF_Stream> CPDF_StreamParser::ReadInlineStream(
CPDF_Document* pDoc,
std::unique_ptr<CPDF_Dictionary> pDict,
CPDF_Object* pCSObj) {
+ if (m_Pos < m_pBuf.size() && PDFCharIsWhitespace(m_pBuf[m_Pos]))
+ m_Pos++;
+
if (m_Pos == m_pBuf.size())
return nullptr;
- if (PDFCharIsWhitespace(m_pBuf[m_Pos]))
- m_Pos++;
-
ByteString Decoder;
CPDF_Dictionary* pParam = nullptr;
CPDF_Object* pFilter = pDict->GetDirectObjectFor("Filter");