summaryrefslogtreecommitdiff
path: root/core/fpdfdoc/cpdf_filespec_unittest.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2017-03-30 11:37:51 -0700
committerChromium commit bot <commit-bot@chromium.org>2017-03-30 19:18:58 +0000
commita69665d11d4eaf5f2d17a46e6be7b43f6c0dbfbe (patch)
tree2a04260c86c166f0a0a9fc299d8ec6c825809c3e /core/fpdfdoc/cpdf_filespec_unittest.cpp
parent1c5e98c6fdd664eda5e6d04835e55125a2117970 (diff)
downloadpdfium-a69665d11d4eaf5f2d17a46e6be7b43f6c0dbfbe.tar.xz
Avoid one more instance of the anti-pattern in 706346.
Need to have a function taking a const CFX_RetainPtr<X>& reference as an argument, assign a different object to a m_ variable of the same type in the function, continue to use the reference after the assignment, and call the function elsewhere with the same m_ variable as the argument while having no other RetainPtrs to the object. Unclear if it is called in this manner, but the first three points hold, so be proactive. Change-Id: I0ece4d7da0b8cf5f3079c53fa612ca07e9632502 Reviewed-on: https://pdfium-review.googlesource.com/3377 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfdoc/cpdf_filespec_unittest.cpp')
0 files changed, 0 insertions, 0 deletions