diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-19 17:33:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-19 17:33:32 +0000 |
| commit | e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd (patch) | |
| tree | 6cf7623219078464910ee438311e24121c8af2a0 /core/fpdfdoc/cpdf_formcontrol.cpp | |
| parent | ed1c58049f0c164969946b6ad0ff06d952ab1949 (diff) | |
| download | pdfium-e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd.tar.xz | |
Move fxcrt::{Byte,Wide}Strings with std::move().chromium/3466
Remove some string copies in barcode that were noticed whilst
looking for moves.
Change-Id: Ieda34d00f633576ba1f0dca283dcdabfb36f236c
Reviewed-on: https://pdfium-review.googlesource.com/35410
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fpdfdoc/cpdf_formcontrol.cpp')
| -rw-r--r-- | core/fpdfdoc/cpdf_formcontrol.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/core/fpdfdoc/cpdf_formcontrol.cpp b/core/fpdfdoc/cpdf_formcontrol.cpp index 2100d4ecee..a80b0294c1 100644 --- a/core/fpdfdoc/cpdf_formcontrol.cpp +++ b/core/fpdfdoc/cpdf_formcontrol.cpp @@ -149,11 +149,10 @@ bool CPDF_FormControl::IsDefaultChecked() const { void CPDF_FormControl::CheckControl(bool bChecked) { ASSERT(GetType() == CPDF_FormField::CheckBox || GetType() == CPDF_FormField::RadioButton); - ByteString csOn = GetOnStateName(); ByteString csOldAS = m_pWidgetDict->GetStringFor("AS", "Off"); ByteString csAS = "Off"; if (bChecked) - csAS = csOn; + csAS = GetOnStateName(); if (csOldAS == csAS) return; m_pWidgetDict->SetNewFor<CPDF_Name>("AS", csAS); |