diff options
author | tsepez <tsepez@chromium.org> | 2016-12-14 05:57:10 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-12-14 05:57:10 -0800 |
commit | a9caab94c1f16929e5acf2676117224617d80f53 (patch) | |
tree | d71ff9a82fae6e6080deb76375f43056127b3ee2 /core/fpdfdoc/cpvt_sectioninfo.cpp | |
parent | 992ecf7c189e5cabf43e5ad862511cf63d030966 (diff) | |
download | pdfium-a9caab94c1f16929e5acf2676117224617d80f53.tar.xz |
Avoid the ptr.reset(new XXX()) anti-pattern
Be suspicious of |new|. This removes some of the
easy cases.
Review-Url: https://codereview.chromium.org/2571913002
Diffstat (limited to 'core/fpdfdoc/cpvt_sectioninfo.cpp')
-rw-r--r-- | core/fpdfdoc/cpvt_sectioninfo.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/core/fpdfdoc/cpvt_sectioninfo.cpp b/core/fpdfdoc/cpvt_sectioninfo.cpp index eb5c1bb809..ec0262c1a0 100644 --- a/core/fpdfdoc/cpvt_sectioninfo.cpp +++ b/core/fpdfdoc/cpvt_sectioninfo.cpp @@ -5,6 +5,7 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include "core/fpdfdoc/cpvt_sectioninfo.h" +#include "third_party/base/ptr_util.h" CPVT_SectionInfo::CPVT_SectionInfo() : rcSection(), nTotalLine(0) {} @@ -21,11 +22,12 @@ void CPVT_SectionInfo::operator=(const CPVT_SectionInfo& other) { rcSection = other.rcSection; nTotalLine = other.nTotalLine; if (other.pSecProps) - pSecProps.reset(new CPVT_SecProps(*other.pSecProps)); + pSecProps = pdfium::MakeUnique<CPVT_SecProps>(*other.pSecProps); else pSecProps.reset(); + if (other.pWordProps) - pWordProps.reset(new CPVT_WordProps(*other.pWordProps)); + pWordProps = pdfium::MakeUnique<CPVT_WordProps>(*other.pWordProps); else pWordProps.reset(); } |