diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-08 09:00:35 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-08 09:00:35 -0700 |
| commit | 8b36e5cc3d5f5f579c6b060e2c40b896a4b02bc0 (patch) | |
| tree | f84a20d330d92b791d0322f424cb155816d77d1b /core/fpdfdoc/doc_action.cpp | |
| parent | 8da140e8747920057a2f2bbcf5c78e40bb198733 (diff) | |
| download | pdfium-8b36e5cc3d5f5f579c6b060e2c40b896a4b02bc0.tar.xz | |
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg
It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
Review URL: https://codereview.chromium.org/1862953004
Diffstat (limited to 'core/fpdfdoc/doc_action.cpp')
| -rw-r--r-- | core/fpdfdoc/doc_action.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/core/fpdfdoc/doc_action.cpp b/core/fpdfdoc/doc_action.cpp index c3ab552606..075849482c 100644 --- a/core/fpdfdoc/doc_action.cpp +++ b/core/fpdfdoc/doc_action.cpp @@ -73,7 +73,8 @@ CFX_WideString CPDF_Action::GetFilePath() const { if (type == "Launch") { CPDF_Dictionary* pWinDict = m_pDict->GetDictBy("Win"); if (pWinDict) { - return CFX_WideString::FromLocal(pWinDict->GetStringBy("F")); + return CFX_WideString::FromLocal( + pWinDict->GetStringBy("F").AsByteStringC()); } } return path; |