diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-11 18:14:56 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-11 18:14:56 -0700 |
| commit | 822484b5f88d92dbcd567b1c2da38af1e720b56f (patch) | |
| tree | de1902c744cbe38023432cc3f860d99df90beb70 /core/fpdfdoc/doc_basic.cpp | |
| parent | e09c1e4db92e28a332f55aa3c80ceb44f4b74287 (diff) | |
| download | pdfium-822484b5f88d92dbcd567b1c2da38af1e720b56f.tar.xz | |
Remove CPDF_Object::GetConstString and overrides
GetConstString() has sharp edges in that when applied to
a CPDF_Number, it must return null whereas GetString() returns
a the stringified number, because of the inability to
control the lifetime of the underlying allocated string.
Deleting this method showed several places where we
actually wanted a *String, not a *StringC, so we were
re-allocating a string we already had.
Review URL: https://codereview.chromium.org/1879683002
Diffstat (limited to 'core/fpdfdoc/doc_basic.cpp')
| -rw-r--r-- | core/fpdfdoc/doc_basic.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/core/fpdfdoc/doc_basic.cpp b/core/fpdfdoc/doc_basic.cpp index 1cfca7e8ee..e0b71df392 100644 --- a/core/fpdfdoc/doc_basic.cpp +++ b/core/fpdfdoc/doc_basic.cpp @@ -316,7 +316,8 @@ bool CPDF_FileSpec::GetFileName(CFX_WideString* csFileName) const { if (CPDF_Dictionary* pDict = m_pObj->AsDictionary()) { *csFileName = pDict->GetUnicodeTextBy("UF"); if (csFileName->IsEmpty()) { - *csFileName = CFX_WideString::FromLocal(pDict->GetConstStringBy("F")); + *csFileName = + CFX_WideString::FromLocal(pDict->GetStringBy("F").AsStringC()); } if (pDict->GetStringBy("FS") == "URL") return true; |