diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-14 11:04:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-14 11:04:57 -0700 |
| commit | 7b1ccf9697692844e764d730079a0f0b98fd6d06 (patch) | |
| tree | 8e1c0b669a8dd1e06de50454b4e5db5e7c6e1a2a /core/fpdfdoc/doc_form.cpp | |
| parent | 774bdde253b8394aa2ac791e273508ff006d813a (diff) | |
| download | pdfium-7b1ccf9697692844e764d730079a0f0b98fd6d06.tar.xz | |
Make CPDF_Dictionary methods take CFX_ByteString arguments
This will help avoid duplicate allocation of CFX_ByteStrings
when the caller already has one. It may seem counter-intuitive
that requiring the caller to pass an allocated CFX_ByteString
rather than a static CFX_ByteStringC would improve the situation,
but due to the idiosyncrasies of std::map, the CPDF_Dictionary
methods must always do an allocation under the covers which
can't be avoided.
The changed callers in this CL are places where we would
previously demote to CFX_ByteStringC and then allocate a
a duplicate CFX_ByteString in the dictionary method.
Review URL: https://codereview.chromium.org/1889863002
Diffstat (limited to 'core/fpdfdoc/doc_form.cpp')
| -rw-r--r-- | core/fpdfdoc/doc_form.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fpdfdoc/doc_form.cpp b/core/fpdfdoc/doc_form.cpp index 6ca40fdaf6..5062b45452 100644 --- a/core/fpdfdoc/doc_form.cpp +++ b/core/fpdfdoc/doc_form.cpp @@ -343,7 +343,7 @@ CFX_ByteString CPDF_InterForm::GenerateNewResourceName( CFX_ByteString bsNum; while (TRUE) { CFX_ByteString csKey = csTmp + bsNum; - if (!pDict->KeyExist(csKey.AsStringC())) { + if (!pDict->KeyExist(csKey)) { return csKey; } if (m < iCount) { |