diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2016-11-21 13:50:32 -0500 |
|---|---|---|
| committer | dan sinclair <dsinclair@chromium.org> | 2016-11-21 18:51:10 +0000 |
| commit | 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 (patch) | |
| tree | e727d747684b9db2632ef250b55046cfce2b55a3 /core/fpdfdoc | |
| parent | 7daa6fb286d1b5d65f99521f3314083e86d93e3f (diff) | |
| download | pdfium-85c8e7f788512ce5b5b43cd816e8091b57c3d5e7.tar.xz | |
Fixup lint flags.
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fpdfdoc')
| -rw-r--r-- | core/fpdfdoc/cpdf_apsettings.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfdoc/cpdf_bookmark.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfdoc/cpdf_defaultappearance.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfdoc/cpdf_interform.cpp | 1 | ||||
| -rw-r--r-- | core/fpdfdoc/cpdf_variabletext.cpp | 2 |
5 files changed, 9 insertions, 0 deletions
diff --git a/core/fpdfdoc/cpdf_apsettings.cpp b/core/fpdfdoc/cpdf_apsettings.cpp index f9127a2720..9fc9c1aa06 100644 --- a/core/fpdfdoc/cpdf_apsettings.cpp +++ b/core/fpdfdoc/cpdf_apsettings.cpp @@ -6,6 +6,8 @@ #include "core/fpdfdoc/cpdf_apsettings.h" +#include <algorithm> + #include "core/fpdfapi/parser/cpdf_array.h" #include "core/fpdfapi/parser/cpdf_dictionary.h" #include "core/fpdfdoc/cpdf_formcontrol.h" diff --git a/core/fpdfdoc/cpdf_bookmark.cpp b/core/fpdfdoc/cpdf_bookmark.cpp index 303f0fcce3..c2c3705717 100644 --- a/core/fpdfdoc/cpdf_bookmark.cpp +++ b/core/fpdfdoc/cpdf_bookmark.cpp @@ -6,6 +6,8 @@ #include "core/fpdfdoc/cpdf_bookmark.h" +#include <memory> + #include "core/fpdfapi/parser/cpdf_array.h" #include "core/fpdfapi/parser/cpdf_string.h" #include "core/fpdfdoc/cpdf_nametree.h" diff --git a/core/fpdfdoc/cpdf_defaultappearance.cpp b/core/fpdfdoc/cpdf_defaultappearance.cpp index 130115bdfb..daf93414bf 100644 --- a/core/fpdfdoc/cpdf_defaultappearance.cpp +++ b/core/fpdfdoc/cpdf_defaultappearance.cpp @@ -6,6 +6,8 @@ #include "core/fpdfdoc/cpdf_defaultappearance.h" +#include <algorithm> + #include "core/fpdfapi/parser/cpdf_simple_parser.h" #include "core/fpdfapi/parser/fpdf_parser_decode.h" #include "core/fpdfdoc/cpdf_formcontrol.h" diff --git a/core/fpdfdoc/cpdf_interform.cpp b/core/fpdfdoc/cpdf_interform.cpp index 377a360d9e..00365c7224 100644 --- a/core/fpdfdoc/cpdf_interform.cpp +++ b/core/fpdfdoc/cpdf_interform.cpp @@ -364,6 +364,7 @@ bool RetrieveSpecificFont(uint8_t charSet, lf.lfPitchAndFamily = pitchAndFamily; if (pcsFontName) { // TODO(dsinclair): Should this be strncpy? + // NOLINTNEXTLINE(runtime/printf) strcpy(lf.lfFaceName, pcsFontName); } return RetrieveSpecificFont(lf); diff --git a/core/fpdfdoc/cpdf_variabletext.cpp b/core/fpdfdoc/cpdf_variabletext.cpp index 5fe8c0137e..5cc7e9bf11 100644 --- a/core/fpdfdoc/cpdf_variabletext.cpp +++ b/core/fpdfdoc/cpdf_variabletext.cpp @@ -6,6 +6,8 @@ #include "core/fpdfdoc/cpdf_variabletext.h" +#include <algorithm> + #include "core/fpdfapi/font/cpdf_font.h" #include "core/fpdfdoc/cline.h" #include "core/fpdfdoc/cpvt_section.h" |