diff options
| author | Nicolas Pena <npm@chromium.org> | 2017-06-20 17:42:39 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-06-20 22:10:32 +0000 |
| commit | 995a601c50874729ac40e2cc444b8894cf2aea96 (patch) | |
| tree | f2429607324df0be7585c2099505444e0247ef1f /core/fpdfdoc | |
| parent | dce2d72f9fbc166ee8eed0e362ab26e1e1a33cdd (diff) | |
| download | pdfium-995a601c50874729ac40e2cc444b8894cf2aea96.tar.xz | |
Cleanup fpdf_parser_decode
This CL fixes some nits in fpdf_parser_decode, especially avoiding non-const
reference parameters.
Change-Id: Ibb914850afd924bb398f886ac862f7589519ef7e
Reviewed-on: https://pdfium-review.googlesource.com/6750
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fpdfdoc')
| -rw-r--r-- | core/fpdfdoc/cpdf_formfield.cpp | 3 | ||||
| -rw-r--r-- | core/fpdfdoc/cpvt_generateap.cpp | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/core/fpdfdoc/cpdf_formfield.cpp b/core/fpdfdoc/cpdf_formfield.cpp index cd47f269bc..acb46a5beb 100644 --- a/core/fpdfdoc/cpdf_formfield.cpp +++ b/core/fpdfdoc/cpdf_formfield.cpp @@ -662,8 +662,7 @@ int CPDF_FormField::InsertOption(CFX_WideString csOptLabel, if (bNotify && !NotifyListOrComboBoxBeforeChange(csOptLabel)) return -1; - CFX_ByteString csStr = - PDF_EncodeText(csOptLabel.c_str(), csOptLabel.GetLength()); + CFX_ByteString csStr = PDF_EncodeText(csOptLabel); CPDF_Array* pOpt = ToArray(FPDF_GetFieldAttr(m_pDict.Get(), "Opt")); if (!pOpt) pOpt = m_pDict->SetNewFor<CPDF_Array>("Opt"); diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp index bcd3aa1d00..d542e8cb32 100644 --- a/core/fpdfdoc/cpvt_generateap.cpp +++ b/core/fpdfdoc/cpvt_generateap.cpp @@ -1348,7 +1348,7 @@ CFX_ByteString CPVT_GenerateAP::GetPDFWordString(IPVT_FontMap* pFontMap, CFX_ByteString CPVT_GenerateAP::GetWordRenderString( const CFX_ByteString& strWords) { if (strWords.GetLength() > 0) - return PDF_EncodeString(strWords) + " Tj\n"; + return PDF_EncodeString(strWords, false) + " Tj\n"; return ""; } |