diff options
author | Ryan Harrison <rharrison@chromium.org> | 2018-02-13 22:11:43 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-13 22:11:43 +0000 |
commit | dab8649b70284a3f0e109510996c35c7882cbd87 (patch) | |
tree | d133a06761c5a51d93f5e548163333756f06bac4 /core/fxcodec/codec/ccodec_bmpmodule.cpp | |
parent | 9bf1a5efde45cd99be11c530232df349c3eb5295 (diff) | |
download | pdfium-dab8649b70284a3f0e109510996c35c7882cbd87.tar.xz |
Change return value of GetAvailInput
This changes the return value from uint32_t to FX_FILESIZE, which is
the type the methods is uses return. The existing code does an
unguarded static cast, so something like -1 could cause a very large
value being returned.
This change has a cascading impact up to the top of the progressive
codec, which now has to handle negative values gracefully.
Change-Id: I813fb71e932dd5da014dbaed0dbf3bb28f8d4e9f
Reviewed-on: https://pdfium-review.googlesource.com/26450
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcodec/codec/ccodec_bmpmodule.cpp')
-rw-r--r-- | core/fxcodec/codec/ccodec_bmpmodule.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fxcodec/codec/ccodec_bmpmodule.cpp b/core/fxcodec/codec/ccodec_bmpmodule.cpp index e41b3dfd60..eb9bdf84f5 100644 --- a/core/fxcodec/codec/ccodec_bmpmodule.cpp +++ b/core/fxcodec/codec/ccodec_bmpmodule.cpp @@ -63,8 +63,8 @@ int32_t CCodec_BmpModule::LoadImage(Context* pContext) { return ctx->m_Bmp.DecodeImage(); } -uint32_t CCodec_BmpModule::GetAvailInput(Context* pContext, - uint8_t** avail_buf_ptr) { +FX_FILESIZE CCodec_BmpModule::GetAvailInput(Context* pContext, + uint8_t** avail_buf_ptr) { auto* ctx = static_cast<CFX_BmpContext*>(pContext); return ctx->m_Bmp.GetAvailInput(avail_buf_ptr); } |