summaryrefslogtreecommitdiff
path: root/core/fxcodec
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-09-04 19:59:03 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-09-04 19:59:03 +0000
commit76188c505dac5c4e35911edbc97d0dacbe366038 (patch)
tree91b8413cbf748a38b39f391472b77d201ecc8f39 /core/fxcodec
parent73e97f4fac2f4f591ff62e70377a80fd40b5f6f3 (diff)
downloadpdfium-76188c505dac5c4e35911edbc97d0dacbe366038.tar.xz
Fix some more span/memcpy interactions.
Use the preferred idiom of creating a subspan, which makes the proper checks prior to the copy. Change-Id: Ia7f25b5760dea5707df66cf421195b23a1ce0ad0 Reviewed-on: https://pdfium-review.googlesource.com/41911 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcodec')
-rw-r--r--core/fxcodec/codec/fx_codec.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/core/fxcodec/codec/fx_codec.cpp b/core/fxcodec/codec/fx_codec.cpp
index efae53908e..b93f5418f3 100644
--- a/core/fxcodec/codec/fx_codec.cpp
+++ b/core/fxcodec/codec/fx_codec.cpp
@@ -1642,7 +1642,8 @@ uint8_t* CCodec_RLScanlineDecoder::v_GetNextLine() {
copy_len = m_SrcBuf.size() - m_SrcOffset;
m_bEOD = true;
}
- memcpy(m_pScanline.get() + col_pos, &m_SrcBuf[m_SrcOffset], copy_len);
+ auto copy_span = m_SrcBuf.subspan(m_SrcOffset, copy_len);
+ memcpy(m_pScanline.get() + col_pos, copy_span.data(), copy_span.size());
col_pos += copy_len;
UpdateOperator((uint8_t)copy_len);
} else if (m_Operator > 128) {