diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-09-25 20:07:29 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-09-25 20:07:29 +0000 |
| commit | 2a1cbc0417985485ab660ee6fd98c3bbedf716cd (patch) | |
| tree | 280fc0b1860a6f2757f70c0382b0ae0464c0c9d2 /core/fxcodec | |
| parent | 30dc6aaf878b2c55efcf7598fdb8886e06d14e01 (diff) | |
| download | pdfium-2a1cbc0417985485ab660ee6fd98c3bbedf716cd.tar.xz | |
Revert "Remove unreachable code in CPDF_DIBBase."
This reverts commit 214982c4d02a720c3b1b3de121cddc62189b8848.
Reason for revert: Turns out it is reachable.
Original change's description:
> Remove unreachable code in CPDF_DIBBase.
>
> The colorspace is always available when creating image decoders that use
> colorspaces.
>
> Change-Id: I20ac75edcd614ccc1e83de262c128776e9d03eed
> Reviewed-on: https://pdfium-review.googlesource.com/42872
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
TBR=thestig@chromium.org,rharrison@chromium.org
BUG=chromium:888743
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I45903543f0e4bf2785660fb8c1e45c34febb6ecf
Reviewed-on: https://pdfium-review.googlesource.com/43050
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcodec')
| -rw-r--r-- | core/fxcodec/codec/ccodec_jpxmodule.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/core/fxcodec/codec/ccodec_jpxmodule.cpp b/core/fxcodec/codec/ccodec_jpxmodule.cpp index 2465ea7bd0..28221be340 100644 --- a/core/fxcodec/codec/ccodec_jpxmodule.cpp +++ b/core/fxcodec/codec/ccodec_jpxmodule.cpp @@ -646,8 +646,6 @@ CCodec_JpxModule::~CCodec_JpxModule() {} std::unique_ptr<CJPX_Decoder> CCodec_JpxModule::CreateDecoder( pdfium::span<const uint8_t> src_span, CPDF_ColorSpace* cs) { - // TODO(thestig): |cs| should never be nullptr in production, but - // pdf_jpx_fuzzer.cc passes that in. auto decoder = pdfium::MakeUnique<CJPX_Decoder>(cs); if (!decoder->Init(src_span)) return nullptr; |