diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-04-16 17:28:17 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-16 17:28:17 +0000 |
| commit | 3d523e3cf89440e2ffc6571b1c687ad5e3f0318f (patch) | |
| tree | b546904778c288c9ee9100f8e9da2761a9acc2cb /core/fxcrt/bytestring.h | |
| parent | c51196cac2963d94cb0c6434f870fcea83d5c509 (diff) | |
| download | pdfium-3d523e3cf89440e2ffc6571b1c687ad5e3f0318f.tar.xz | |
Revert "Return pdfium::span<char> from ByteString::GetBuffer()."
This reverts commit 80a6cbe0a427e155de8555bc867af745d10f9777.
Reason for revert: too many abrts in beta branch.
TBR: dsinclair@chromium.org
Bug: 832557, 832978, 832992, 833062, 833097
Change-Id: I7d511dbb224ddc644be96ea2f3770ad6f73debf5
Reviewed-on: https://pdfium-review.googlesource.com/30792
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fxcrt/bytestring.h')
| -rw-r--r-- | core/fxcrt/bytestring.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/core/fxcrt/bytestring.h b/core/fxcrt/bytestring.h index 247238573d..ccb539b2ef 100644 --- a/core/fxcrt/bytestring.h +++ b/core/fxcrt/bytestring.h @@ -17,7 +17,6 @@ #include "core/fxcrt/string_data_template.h" #include "core/fxcrt/string_view_template.h" #include "third_party/base/optional.h" -#include "third_party/base/span.h" namespace fxcrt { @@ -154,10 +153,7 @@ class ByteString { size_t Delete(size_t index, size_t count = 1); void Reserve(size_t len); - - // Note: any modification of the string (including ReleaseBuffer()) may - // invalidate the span, which must not outlive its buffer. - pdfium::span<char> GetBuffer(size_t len); + char* GetBuffer(size_t len); void ReleaseBuffer(size_t len); ByteString Mid(size_t first, size_t count) const; |