summaryrefslogtreecommitdiff
path: root/core/fxcrt/cfx_bytestring_unittest.cpp
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2017-07-27 16:28:44 -0400
committerChromium commit bot <commit-bot@chromium.org>2017-07-27 21:05:23 +0000
commit33805cc811c722a0c5cd439cff419de252cd39c9 (patch)
treebb6ef4484ff62486e4cc0ea49642278b5da1b746 /core/fxcrt/cfx_bytestring_unittest.cpp
parent4191b03e29ef54f37deeadf652ee11cbfb81f9df (diff)
downloadpdfium-33805cc811c722a0c5cd439cff419de252cd39c9.tar.xz
Remove single param Mid() method from string classes
This support is being removed from CFX_ByteString, CFX_ByteStringC, CFX_WideString, and CFX_WideStringC. This standardizes all of these classes to only have one Mid method that takes in 2 params, offset and count. Count now must be positive. The old behaviour of calculating the length for the user if -1 is passed in for the count has been removed. This work is in preperation for converting these classes to not accept negative lengths anywhere and thus make the underlying size type unsigned. BUG=pdfium:828 Change-Id: I5f15e7b7b00b264231817f143e2da88ee6f69e7b Reviewed-on: https://pdfium-review.googlesource.com/9430 Reviewed-by: (OOO Jul 28 - Aug 8) dsinclair <dsinclair@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/cfx_bytestring_unittest.cpp')
-rw-r--r--core/fxcrt/cfx_bytestring_unittest.cpp11
1 files changed, 4 insertions, 7 deletions
diff --git a/core/fxcrt/cfx_bytestring_unittest.cpp b/core/fxcrt/cfx_bytestring_unittest.cpp
index f5d9413b7d..bcf6f7495e 100644
--- a/core/fxcrt/cfx_bytestring_unittest.cpp
+++ b/core/fxcrt/cfx_bytestring_unittest.cpp
@@ -440,10 +440,10 @@ TEST(fxcrt, ByteStringMid) {
CFX_ByteString fred("FRED");
EXPECT_EQ("", fred.Mid(0, 0));
EXPECT_EQ("", fred.Mid(3, 0));
- EXPECT_EQ("FRED", fred.Mid(0));
- EXPECT_EQ("RED", fred.Mid(1));
- EXPECT_EQ("ED", fred.Mid(2));
- EXPECT_EQ("D", fred.Mid(3));
+ EXPECT_EQ("FRED", fred.Mid(0, 4));
+ EXPECT_EQ("RED", fred.Mid(1, 3));
+ EXPECT_EQ("ED", fred.Mid(2, 2));
+ EXPECT_EQ("D", fred.Mid(3, 1));
EXPECT_EQ("F", fred.Mid(0, 1));
EXPECT_EQ("R", fred.Mid(1, 1));
EXPECT_EQ("E", fred.Mid(2, 1));
@@ -458,9 +458,6 @@ TEST(fxcrt, ByteStringMid) {
CFX_ByteString empty;
EXPECT_EQ("", empty.Mid(0, 0));
- EXPECT_EQ("", empty.Mid(0));
- EXPECT_EQ("", empty.Mid(1));
- EXPECT_EQ("", empty.Mid(-1));
}
TEST(fxcrt, ByteStringLeft) {