diff options
| author | Ryan Harrison <rharrison@chromium.org> | 2017-08-02 16:36:37 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-02 20:52:11 +0000 |
| commit | 17e54528fe0a2203074f4d086677d14c33cf7253 (patch) | |
| tree | 3c85bb3384a837617031269f7fa52e5fa84b7ed9 /core/fxcrt/cfx_bytestring_unittest.cpp | |
| parent | 0811da801dd72e2e0af2d7b9d1e866162df2cee1 (diff) | |
| download | pdfium-17e54528fe0a2203074f4d086677d14c33cf7253.tar.xz | |
Remove parameter from GetID
All of the call sites for this method used the default value, so it
has been removed. This simplifies converting FX_STRSIZE to be
unsigned, since the removed parameter was of this type.
BUG=pdfium:828
Change-Id: I369285aed561731ab34ec6d30de0d21fb3431492
Reviewed-on: https://pdfium-review.googlesource.com/9891
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/cfx_bytestring_unittest.cpp')
| -rw-r--r-- | core/fxcrt/cfx_bytestring_unittest.cpp | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/core/fxcrt/cfx_bytestring_unittest.cpp b/core/fxcrt/cfx_bytestring_unittest.cpp index d843afef97..b79a765e20 100644 --- a/core/fxcrt/cfx_bytestring_unittest.cpp +++ b/core/fxcrt/cfx_bytestring_unittest.cpp @@ -835,33 +835,15 @@ TEST(fxcrt, ByteStringCFromVector) { TEST(fxcrt, ByteStringCGetID) { CFX_ByteStringC null_string; EXPECT_EQ(0u, null_string.GetID()); - EXPECT_EQ(0u, null_string.GetID(1)); - EXPECT_EQ(0u, null_string.GetID(-1)); - EXPECT_EQ(0u, null_string.GetID(-1000000)); CFX_ByteStringC empty_string(""); EXPECT_EQ(0u, empty_string.GetID()); - EXPECT_EQ(0u, empty_string.GetID(1)); - EXPECT_EQ(0u, empty_string.GetID(-1)); - EXPECT_EQ(0u, empty_string.GetID(-1000000)); CFX_ByteStringC short_string("ab"); EXPECT_EQ(FXBSTR_ID('a', 'b', 0, 0), short_string.GetID()); - EXPECT_EQ(FXBSTR_ID('b', 0, 0, 0), short_string.GetID(1)); - EXPECT_EQ(0u, short_string.GetID(2)); - EXPECT_EQ(0u, short_string.GetID(-1)); - EXPECT_EQ(0u, short_string.GetID(-1000000)); CFX_ByteStringC longer_string("abcdef"); EXPECT_EQ(FXBSTR_ID('a', 'b', 'c', 'd'), longer_string.GetID()); - EXPECT_EQ(FXBSTR_ID('b', 'c', 'd', 'e'), longer_string.GetID(1)); - EXPECT_EQ(FXBSTR_ID('c', 'd', 'e', 'f'), longer_string.GetID(2)); - EXPECT_EQ(FXBSTR_ID('d', 'e', 'f', 0), longer_string.GetID(3)); - EXPECT_EQ(FXBSTR_ID('e', 'f', 0, 0), longer_string.GetID(4)); - EXPECT_EQ(FXBSTR_ID('f', 0, 0, 0), longer_string.GetID(5)); - EXPECT_EQ(0u, longer_string.GetID(6)); - EXPECT_EQ(0u, longer_string.GetID(-1)); - EXPECT_EQ(0u, longer_string.GetID(-1000000)); } TEST(fxcrt, ByteStringCFind) { |