diff options
author | tsepez <tsepez@chromium.org> | 2016-08-26 16:52:33 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-08-26 16:52:33 -0700 |
commit | c10c23a2b1999b1cb0354fd4db9837dc63a3d833 (patch) | |
tree | 2f5b9f35d372de26476411295120146baa93f5fb /core/fxcrt/cfx_count_ref_unittest.cpp | |
parent | 9ed91376d562f3c6e7ca0a99035a74502f648776 (diff) | |
download | pdfium-c10c23a2b1999b1cb0354fd4db9837dc63a3d833.tar.xz |
Add -> operators to CFX_CountRef.chromium/2842
Allows CFX_CountRefs to behave more like pointers.
Rename SetNull() to Clear() for consistency with other ptrs.
Change GetPrivateCopy() into MakePrivateCopy() with no return,
since the -> operators are clearer than getting an object pointer.
Review-Url: https://codereview.chromium.org/2283113002
Diffstat (limited to 'core/fxcrt/cfx_count_ref_unittest.cpp')
-rw-r--r-- | core/fxcrt/cfx_count_ref_unittest.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/core/fxcrt/cfx_count_ref_unittest.cpp b/core/fxcrt/cfx_count_ref_unittest.cpp index 7651c93f25..2a36292b54 100644 --- a/core/fxcrt/cfx_count_ref_unittest.cpp +++ b/core/fxcrt/cfx_count_ref_unittest.cpp @@ -109,16 +109,19 @@ TEST(fxcrt, CountRefGetModify) { Observer observer; { CFX_CountRef<Object> ptr; - EXPECT_NE(nullptr, ptr.GetPrivateCopy(&observer, std::string("one"))); + ptr.MakePrivateCopy(&observer, std::string("one")); + EXPECT_NE(nullptr, ptr.GetObject()); EXPECT_EQ(1, observer.GetConstructionCount("one")); EXPECT_EQ(0, observer.GetDestructionCount("one")); - EXPECT_NE(nullptr, ptr.GetPrivateCopy(&observer, std::string("one"))); + ptr.MakePrivateCopy(&observer, std::string("one")); + EXPECT_NE(nullptr, ptr.GetObject()); EXPECT_EQ(1, observer.GetConstructionCount("one")); EXPECT_EQ(0, observer.GetDestructionCount("one")); { CFX_CountRef<Object> other(ptr); - EXPECT_NE(nullptr, ptr.GetPrivateCopy(&observer, std::string("one"))); + ptr.MakePrivateCopy(&observer, std::string("one")); + EXPECT_NE(nullptr, ptr.GetObject()); EXPECT_EQ(2, observer.GetConstructionCount("one")); EXPECT_EQ(0, observer.GetDestructionCount("one")); } |