diff options
author | tsepez <tsepez@chromium.org> | 2016-11-23 14:20:19 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-11-23 14:20:19 -0800 |
commit | 81b224669647c9dd3c5ea2e013ee3cc109744bb8 (patch) | |
tree | eb3d718b2be01b04fab9586c0b9f94035d1077d6 /core/fxcrt/cfx_maybe_owned_unittest.cpp | |
parent | 9067fd683ebf8d6467f8cc5aa7daf5e1f950f846 (diff) | |
download | pdfium-81b224669647c9dd3c5ea2e013ee3cc109744bb8.tar.xz |
Add CFX_MaybeOwned<> template.
This will allow us to get rid of more .release()s of unique_ptrs,
as shown by the changed cpdf_colorspace usage.
Review-Url: https://codereview.chromium.org/2526903002
Diffstat (limited to 'core/fxcrt/cfx_maybe_owned_unittest.cpp')
-rw-r--r-- | core/fxcrt/cfx_maybe_owned_unittest.cpp | 179 |
1 files changed, 179 insertions, 0 deletions
diff --git a/core/fxcrt/cfx_maybe_owned_unittest.cpp b/core/fxcrt/cfx_maybe_owned_unittest.cpp new file mode 100644 index 0000000000..8f513a358d --- /dev/null +++ b/core/fxcrt/cfx_maybe_owned_unittest.cpp @@ -0,0 +1,179 @@ +// Copyright 2016 PDFium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "core/fxcrt/cfx_maybe_owned.h" + +#include <memory> +#include <utility> + +#include "core/fxcrt/fx_memory.h" +#include "testing/fx_string_testhelpers.h" +#include "testing/gtest/include/gtest/gtest.h" +#include "third_party/base/ptr_util.h" + +namespace { + +class PseudoDeletable { + public: + explicit PseudoDeletable(int id, int* count_location) + : id_(id), count_location_(count_location) {} + ~PseudoDeletable() { ++(*count_location_); } + int GetID() const { return id_; } + + private: + int id_; + int* count_location_; +}; + +} // namespace + +TEST(fxcrt, MaybeOwnedNull) { + CFX_MaybeOwned<PseudoDeletable> ptr1; + EXPECT_FALSE(ptr1.IsOwned()); + EXPECT_FALSE(ptr1); + EXPECT_EQ(nullptr, ptr1.Get()); + + CFX_MaybeOwned<PseudoDeletable> ptr2; + EXPECT_TRUE(ptr1 == ptr2); + EXPECT_FALSE(ptr1 != ptr2); +} + +TEST(fxcrt, MaybeOwnedNotOwned) { + int delete_count = 0; + PseudoDeletable thing1(100, &delete_count); + { + CFX_MaybeOwned<PseudoDeletable> ptr(&thing1); + EXPECT_FALSE(ptr.IsOwned()); + EXPECT_EQ(ptr.Get(), &thing1); + EXPECT_EQ(100, ptr->GetID()); + EXPECT_TRUE(ptr == &thing1); + EXPECT_FALSE(ptr != &thing1); + + CFX_MaybeOwned<PseudoDeletable> empty; + EXPECT_FALSE(ptr == empty); + EXPECT_TRUE(ptr != empty); + } + EXPECT_EQ(0, delete_count); + + delete_count = 0; + PseudoDeletable thing2(200, &delete_count); + { + CFX_MaybeOwned<PseudoDeletable> ptr(&thing1); + ptr = &thing2; + EXPECT_FALSE(ptr.IsOwned()); + EXPECT_EQ(ptr.Get(), &thing2); + EXPECT_EQ(200, ptr->GetID()); + } + EXPECT_EQ(0, delete_count); + + delete_count = 0; + int owned_delete_count = 0; + { + CFX_MaybeOwned<PseudoDeletable> ptr(&thing1); + EXPECT_EQ(100, ptr->GetID()); + ptr = pdfium::MakeUnique<PseudoDeletable>(300, &owned_delete_count); + EXPECT_TRUE(ptr.IsOwned()); + EXPECT_EQ(300, ptr->GetID()); + } + EXPECT_EQ(0, delete_count); + EXPECT_EQ(1, owned_delete_count); +} + +TEST(fxcrt, MaybeOwnedOwned) { + int delete_count = 0; + { + CFX_MaybeOwned<PseudoDeletable> ptr( + pdfium::MakeUnique<PseudoDeletable>(100, &delete_count)); + EXPECT_TRUE(ptr.IsOwned()); + EXPECT_EQ(100, ptr->GetID()); + + CFX_MaybeOwned<PseudoDeletable> empty; + EXPECT_FALSE(ptr == empty); + EXPECT_TRUE(ptr != empty); + } + EXPECT_EQ(1, delete_count); + + delete_count = 0; + { + CFX_MaybeOwned<PseudoDeletable> ptr( + pdfium::MakeUnique<PseudoDeletable>(200, &delete_count)); + ptr = pdfium::MakeUnique<PseudoDeletable>(300, &delete_count); + EXPECT_TRUE(ptr.IsOwned()); + EXPECT_EQ(300, ptr->GetID()); + EXPECT_EQ(1, delete_count); + } + EXPECT_EQ(2, delete_count); + + delete_count = 0; + int unowned_delete_count = 0; + PseudoDeletable thing2(400, &unowned_delete_count); + { + CFX_MaybeOwned<PseudoDeletable> ptr( + pdfium::MakeUnique<PseudoDeletable>(500, &delete_count)); + ptr = &thing2; + EXPECT_FALSE(ptr.IsOwned()); + EXPECT_EQ(400, ptr->GetID()); + EXPECT_EQ(1, delete_count); + EXPECT_EQ(0, unowned_delete_count); + } + EXPECT_EQ(1, delete_count); + EXPECT_EQ(0, unowned_delete_count); +} + +TEST(fxcrt, MaybeOwnedRelease) { + int delete_count = 0; + { + std::unique_ptr<PseudoDeletable> stolen; + { + CFX_MaybeOwned<PseudoDeletable> ptr( + pdfium::MakeUnique<PseudoDeletable>(100, &delete_count)); + EXPECT_TRUE(ptr.IsOwned()); + stolen = ptr.Release(); + EXPECT_FALSE(ptr.IsOwned()); + EXPECT_EQ(ptr, stolen); + EXPECT_EQ(0, delete_count); + } + EXPECT_EQ(0, delete_count); + } + EXPECT_EQ(1, delete_count); +} + +TEST(fxcrt, MaybeOwnedMove) { + int delete_count = 0; + PseudoDeletable thing1(100, &delete_count); + { + CFX_MaybeOwned<PseudoDeletable> ptr1(&thing1); + CFX_MaybeOwned<PseudoDeletable> ptr2( + pdfium::MakeUnique<PseudoDeletable>(200, &delete_count)); + EXPECT_FALSE(ptr1.IsOwned()); + EXPECT_TRUE(ptr2.IsOwned()); + + CFX_MaybeOwned<PseudoDeletable> ptr3(std::move(ptr1)); + CFX_MaybeOwned<PseudoDeletable> ptr4(std::move(ptr2)); + EXPECT_FALSE(ptr1.IsOwned()); + EXPECT_FALSE(ptr2.IsOwned()); + EXPECT_FALSE(ptr3.IsOwned()); + EXPECT_TRUE(ptr4.IsOwned()); + EXPECT_EQ(0, delete_count); + EXPECT_EQ(nullptr, ptr1.Get()); + EXPECT_EQ(nullptr, ptr2.Get()); + EXPECT_EQ(100, ptr3->GetID()); + EXPECT_EQ(200, ptr4->GetID()); + + CFX_MaybeOwned<PseudoDeletable> ptr5; + CFX_MaybeOwned<PseudoDeletable> ptr6; + ptr5 = std::move(ptr3); + ptr6 = std::move(ptr4); + EXPECT_FALSE(ptr3.IsOwned()); + EXPECT_FALSE(ptr4.IsOwned()); + EXPECT_FALSE(ptr5.IsOwned()); + EXPECT_TRUE(ptr6.IsOwned()); + EXPECT_EQ(0, delete_count); + EXPECT_EQ(nullptr, ptr3.Get()); + EXPECT_EQ(nullptr, ptr4.Get()); + EXPECT_EQ(100, ptr5->GetID()); + EXPECT_EQ(200, ptr6->GetID()); + } + EXPECT_EQ(1, delete_count); +} |