summaryrefslogtreecommitdiff
path: root/core/fxcrt/cfx_observable_unittest.cpp
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-09-12 09:47:52 -0700
committerCommit bot <commit-bot@chromium.org>2016-09-12 09:47:52 -0700
commit1c62054a42cf0759148501a36c541de5d5769d32 (patch)
treeed2e53f26474dff1149ce83d3f175c3c36b31631 /core/fxcrt/cfx_observable_unittest.cpp
parent75f84a56fed36111ece82d0ac96e87289622b093 (diff)
downloadpdfium-1c62054a42cf0759148501a36c541de5d5769d32.tar.xz
Make CFX_Obeservable::Observer into a pointer-ish type;
This may be a better design because it avoids having a level of indirection that the Observer required. Review-Url: https://codereview.chromium.org/2326763002
Diffstat (limited to 'core/fxcrt/cfx_observable_unittest.cpp')
-rw-r--r--core/fxcrt/cfx_observable_unittest.cpp114
1 files changed, 114 insertions, 0 deletions
diff --git a/core/fxcrt/cfx_observable_unittest.cpp b/core/fxcrt/cfx_observable_unittest.cpp
new file mode 100644
index 0000000000..eaadd95bb6
--- /dev/null
+++ b/core/fxcrt/cfx_observable_unittest.cpp
@@ -0,0 +1,114 @@
+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/fxcrt/include/cfx_observable.h"
+
+#include <utility>
+
+#include "testing/fx_string_testhelpers.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class PseudoObservable : public CFX_Observable<PseudoObservable> {
+ public:
+ PseudoObservable() {}
+ int SomeMethod() { return 42; }
+ size_t ActiveObservedPtrs() const { return ActiveObservedPtrsForTesting(); }
+};
+
+} // namespace
+
+TEST(fxcrt, ObservePtrNull) {
+ PseudoObservable::ObservedPtr ptr;
+ EXPECT_EQ(nullptr, ptr.Get());
+}
+
+TEST(fxcrt, ObservePtrLivesLonger) {
+ PseudoObservable* pObs = new PseudoObservable;
+ PseudoObservable::ObservedPtr ptr(pObs);
+ EXPECT_NE(nullptr, ptr.Get());
+ EXPECT_EQ(1u, pObs->ActiveObservedPtrs());
+ delete pObs;
+ EXPECT_EQ(nullptr, ptr.Get());
+}
+
+TEST(fxcrt, ObservePtrLivesShorter) {
+ PseudoObservable obs;
+ {
+ PseudoObservable::ObservedPtr ptr(&obs);
+ EXPECT_NE(nullptr, ptr.Get());
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ }
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObservePtrResetNull) {
+ PseudoObservable obs;
+ PseudoObservable::ObservedPtr ptr(&obs);
+ EXPECT_EQ(1u, obs.ActiveObservedPtrs());
+ ptr.Reset();
+ EXPECT_EQ(0u, obs.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObservePtrReset) {
+ PseudoObservable obs1;
+ PseudoObservable obs2;
+ PseudoObservable::ObservedPtr ptr(&obs1);
+ EXPECT_EQ(1u, obs1.ActiveObservedPtrs());
+ EXPECT_EQ(0u, obs2.ActiveObservedPtrs());
+ ptr.Reset(&obs2);
+ EXPECT_EQ(0u, obs1.ActiveObservedPtrs());
+ EXPECT_EQ(1u, obs2.ActiveObservedPtrs());
+}
+
+TEST(fxcrt, ObservePtrEquals) {
+ PseudoObservable obj1;
+ PseudoObservable obj2;
+ PseudoObservable::ObservedPtr null_ptr1;
+ PseudoObservable::ObservedPtr obj1_ptr1(&obj1);
+ PseudoObservable::ObservedPtr obj2_ptr1(&obj2);
+ {
+ PseudoObservable::ObservedPtr null_ptr2;
+ EXPECT_TRUE(null_ptr1 == null_ptr2);
+
+ PseudoObservable::ObservedPtr obj1_ptr2(&obj1);
+ EXPECT_TRUE(obj1_ptr1 == obj1_ptr2);
+
+ PseudoObservable::ObservedPtr obj2_ptr2(&obj2);
+ EXPECT_TRUE(obj2_ptr1 == obj2_ptr2);
+ }
+ EXPECT_FALSE(null_ptr1 == obj1_ptr1);
+ EXPECT_FALSE(null_ptr1 == obj2_ptr1);
+ EXPECT_FALSE(obj1_ptr1 == obj2_ptr1);
+}
+
+TEST(fxcrt, ObservePtrNotEquals) {
+ PseudoObservable obj1;
+ PseudoObservable obj2;
+ PseudoObservable::ObservedPtr null_ptr1;
+ PseudoObservable::ObservedPtr obj1_ptr1(&obj1);
+ PseudoObservable::ObservedPtr obj2_ptr1(&obj2);
+ {
+ PseudoObservable::ObservedPtr null_ptr2;
+ PseudoObservable::ObservedPtr obj1_ptr2(&obj1);
+ PseudoObservable::ObservedPtr obj2_ptr2(&obj2);
+ EXPECT_FALSE(null_ptr1 != null_ptr2);
+ EXPECT_FALSE(obj1_ptr1 != obj1_ptr2);
+ EXPECT_FALSE(obj2_ptr1 != obj2_ptr2);
+ }
+ EXPECT_TRUE(null_ptr1 != obj1_ptr1);
+ EXPECT_TRUE(null_ptr1 != obj2_ptr1);
+ EXPECT_TRUE(obj1_ptr1 != obj2_ptr1);
+}
+
+TEST(fxcrt, ObservePtrBool) {
+ PseudoObservable obj1;
+ PseudoObservable::ObservedPtr null_ptr;
+ PseudoObservable::ObservedPtr obj1_ptr(&obj1);
+ bool null_bool = !!null_ptr;
+ bool obj1_bool = !!obj1_ptr;
+ EXPECT_FALSE(null_bool);
+ EXPECT_TRUE(obj1_bool);
+}