summaryrefslogtreecommitdiff
path: root/core/fxcrt/css/cfx_css.h
diff options
context:
space:
mode:
authorRyan Harrison <rharrison@chromium.org>2018-01-30 20:24:50 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-01-30 20:24:50 +0000
commit802eaea7696e2e1aa8d6d76d1fee39fbe1c7794b (patch)
treefc59e32b58d2c5e7425c825373c3cb2dee5e826a /core/fxcrt/css/cfx_css.h
parent2108e5703531ba4d208817913eee9739d0b74018 (diff)
downloadpdfium-802eaea7696e2e1aa8d6d76d1fee39fbe1c7794b.tar.xz
Clean up CSS Data Table entries and access
This cleans up the entries in the table to no longer have a marker for size, and also removes a hand rolled search. This prevents an out of bounds issue that had been reported and addresses another potential out of bounds issue. BUG=chromium:807214 Change-Id: I3d3ab5a3a174dd4dcec56fa7ee7a0e6c2805bfaa Reviewed-on: https://pdfium-review.googlesource.com/24690 Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/css/cfx_css.h')
-rw-r--r--core/fxcrt/css/cfx_css.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/core/fxcrt/css/cfx_css.h b/core/fxcrt/css/cfx_css.h
index 7b1d7d3f99..3703394d4f 100644
--- a/core/fxcrt/css/cfx_css.h
+++ b/core/fxcrt/css/cfx_css.h
@@ -79,6 +79,8 @@ enum class CFX_CSSPropertyValue : uint8_t {
LAST_MARKER
};
+// Any entries added/removed here, will need to be mirrored in
+// g_CFX_CSSProperties.
enum class CFX_CSSProperty : uint8_t {
BorderLeft = 0,
Top,
@@ -120,7 +122,6 @@ enum class CFX_CSSProperty : uint8_t {
Padding,
MarginBottom,
MarginTop,
- LAST_MARKER
};
enum class CFX_CSSSelectorType : uint8_t { Element = 0, Descendant };