diff options
author | Lei Zhang <thestig@chromium.org> | 2017-11-21 22:07:50 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-21 22:07:50 +0000 |
commit | 56e04d2656bdd5f2b9448d857e8e73ab16aadf8e (patch) | |
tree | 57ed8ebed62f498bdd1fe010b0909f162bbcd29c /core/fxcrt/css/cfx_cssvaluelistparser.h | |
parent | ebe865db548f768038186054fc0f1eb024565c43 (diff) | |
download | pdfium-56e04d2656bdd5f2b9448d857e8e73ab16aadf8e.tar.xz |
Avoid passing pointers by reference in core.
This gets rid of most core/ non-const ref passing, either by passing by
pointer-to-pointer instead, or by returning std::pair.
Change-Id: Id7bdc355a1a725a05f9fa2f1e982ca8c975beef1
Reviewed-on: https://pdfium-review.googlesource.com/19030
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fxcrt/css/cfx_cssvaluelistparser.h')
-rw-r--r-- | core/fxcrt/css/cfx_cssvaluelistparser.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/core/fxcrt/css/cfx_cssvaluelistparser.h b/core/fxcrt/css/cfx_cssvaluelistparser.h index 514db9e192..6872ee278c 100644 --- a/core/fxcrt/css/cfx_cssvaluelistparser.h +++ b/core/fxcrt/css/cfx_cssvaluelistparser.h @@ -14,15 +14,15 @@ class CFX_CSSValueListParser { public: CFX_CSSValueListParser(const wchar_t* psz, int32_t iLen, wchar_t separator); - bool NextValue(CFX_CSSPrimitiveType& eType, - const wchar_t*& pStart, - int32_t& iLength); - - wchar_t m_Separator; + bool NextValue(CFX_CSSPrimitiveType* eType, + const wchar_t** pStart, + int32_t* iLength); + void UseCommaSeparator() { m_Separator = ','; } private: int32_t SkipTo(wchar_t wch, bool breakOnSpace, bool matchBrackets); + wchar_t m_Separator; const wchar_t* m_pCur; const wchar_t* m_pEnd; }; |