diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-12 15:52:14 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-12 15:52:14 -0700 |
| commit | 28c7844c1ef5ea0c8727b890e9ff56b593119a00 (patch) | |
| tree | a96e31bbff3c221a0030e3a8a6501a5f81379d0f /core/fxcrt/fx_basic_bstring.cpp | |
| parent | ade9465067098d9f94a13f61741cebf4bb8aac47 (diff) | |
| download | pdfium-28c7844c1ef5ea0c8727b890e9ff56b593119a00.tar.xz | |
Add CFX_ByteStringC::CharAt() to avoid c_str() and casts.
Most of the time, we want to operate on chars as if they
were unsigned, but there are a few places where we need
the default (questionably signed) values. Consolidate
the casting in a single place rather than forcing callers
to get a char* ptr.
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1972053003
Diffstat (limited to 'core/fxcrt/fx_basic_bstring.cpp')
| -rw-r--r-- | core/fxcrt/fx_basic_bstring.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp index 18e240bc84..e035dd53d1 100644 --- a/core/fxcrt/fx_basic_bstring.cpp +++ b/core/fxcrt/fx_basic_bstring.cpp @@ -99,9 +99,8 @@ CFX_ByteString::CFX_ByteString(char ch) { } CFX_ByteString::CFX_ByteString(const CFX_ByteStringC& stringSrc) { - if (!stringSrc.IsEmpty()) { + if (!stringSrc.IsEmpty()) m_pData.Reset(StringData::Create(stringSrc.c_str(), stringSrc.GetLength())); - } } CFX_ByteString::CFX_ByteString(const CFX_ByteStringC& str1, |