diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-08 09:00:35 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-08 09:00:35 -0700 |
| commit | 8b36e5cc3d5f5f579c6b060e2c40b896a4b02bc0 (patch) | |
| tree | f84a20d330d92b791d0322f424cb155816d77d1b /core/fxcrt/fx_basic_bstring.cpp | |
| parent | 8da140e8747920057a2f2bbcf5c78e40bb198733 (diff) | |
| download | pdfium-8b36e5cc3d5f5f579c6b060e2c40b896a4b02bc0.tar.xz | |
Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg
It doesn't persist the string beyond the duration of the
call, hence it should take the *StringC variant. Doing so
avoids some allocs by changing to the *StringC ctor in a few
places, at the cost of some explicit .ToByteStringC() calls
(which are cheap).
Review URL: https://codereview.chromium.org/1862953004
Diffstat (limited to 'core/fxcrt/fx_basic_bstring.cpp')
| -rw-r--r-- | core/fxcrt/fx_basic_bstring.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fxcrt/fx_basic_bstring.cpp b/core/fxcrt/fx_basic_bstring.cpp index 2c2264a419..cc0dfe2341 100644 --- a/core/fxcrt/fx_basic_bstring.cpp +++ b/core/fxcrt/fx_basic_bstring.cpp @@ -824,7 +824,7 @@ CFX_ByteString CFX_ByteString::FromUnicode(const FX_WCHAR* str, // static CFX_ByteString CFX_ByteString::FromUnicode(const CFX_WideString& str) { - return CFX_CharMap::GetByteString(0, str); + return CFX_CharMap::GetByteString(0, str.AsWideStringC()); } int CFX_ByteString::Compare(const CFX_ByteStringC& str) const { |