Revert "Use CFX_RetainPtr to ref count CFX_ByteString"chromium/2700chromium/2699chromium/2698chromium/2697

This reverts commit ac88953dfa7c1a68c69989d61d7bc03c0595064b.

Reason for revert: Strings borked.
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/1852453004

1 files changed, 6 insertions, 6 deletions

diff --git a/core/fxcrt/fx_basic_bstring_unittest.cpp b/core/fxcrt/fx_basic_bstring_unittest.cpp
index 6e360448c7..834a6e444d 100644
--- a/core/fxcrt/fx_basic_bstring_unittest.cpp
+++ b/core/fxcrt/fx_basic_bstring_unittest.cpp
@@ -288,28 +288,28 @@ TEST(fxcrt, ByteStringCNull) {
   EXPECT_NE(null_string, non_null_string);
 }
 
-TEST(fxcrt, ByteStringConcat) {
+TEST(fxcrt, ByteStringConcatInPlace) {
   CFX_ByteString fred;
-  fred.Concat("FRED", 4);
+  fred.ConcatInPlace(4, "FRED");
   EXPECT_EQ("FRED", fred);
 
-  fred.Concat("DY", 2);
+  fred.ConcatInPlace(2, "DY");
   EXPECT_EQ("FREDDY", fred);
 
   fred.Delete(3, 3);
   EXPECT_EQ("FRE", fred);
 
-  fred.Concat("D", 1);
+  fred.ConcatInPlace(1, "D");
   EXPECT_EQ("FRED", fred);
 
   CFX_ByteString copy = fred;
-  fred.Concat("DY", 2);
+  fred.ConcatInPlace(2, "DY");
   EXPECT_EQ("FREDDY", fred);
   EXPECT_EQ("FRED", copy);
 
   // Test invalid arguments.
   copy = fred;
-  fred.Concat("freddy", -6);
+  fred.ConcatInPlace(-6, "freddy");
   CFX_ByteString not_aliased("xxxxxx");
   EXPECT_EQ("FREDDY", fred);
   EXPECT_EQ("xxxxxx", not_aliased);