diff options
author | tsepez <tsepez@chromium.org> | 2016-03-31 12:54:27 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-31 12:54:27 -0700 |
commit | b33dfdf68bafa30e90a65fb71ff6b343202e0561 (patch) | |
tree | d4cf1773400034265cf0d9a4bba4d824cb5d04a9 /core/fxcrt/fx_basic_bstring_unittest.cpp | |
parent | 62514d9c1794ec73c4b1e0f4d9a2769f2050c502 (diff) | |
download | pdfium-b33dfdf68bafa30e90a65fb71ff6b343202e0561.tar.xz |
Revert "Use CFX_RetainPtr to ref count CFX_ByteString"chromium/2700chromium/2699chromium/2698chromium/2697
This reverts commit ac88953dfa7c1a68c69989d61d7bc03c0595064b.
Reason for revert: Strings borked.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1852453004
Diffstat (limited to 'core/fxcrt/fx_basic_bstring_unittest.cpp')
-rw-r--r-- | core/fxcrt/fx_basic_bstring_unittest.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/core/fxcrt/fx_basic_bstring_unittest.cpp b/core/fxcrt/fx_basic_bstring_unittest.cpp index 6e360448c7..834a6e444d 100644 --- a/core/fxcrt/fx_basic_bstring_unittest.cpp +++ b/core/fxcrt/fx_basic_bstring_unittest.cpp @@ -288,28 +288,28 @@ TEST(fxcrt, ByteStringCNull) { EXPECT_NE(null_string, non_null_string); } -TEST(fxcrt, ByteStringConcat) { +TEST(fxcrt, ByteStringConcatInPlace) { CFX_ByteString fred; - fred.Concat("FRED", 4); + fred.ConcatInPlace(4, "FRED"); EXPECT_EQ("FRED", fred); - fred.Concat("DY", 2); + fred.ConcatInPlace(2, "DY"); EXPECT_EQ("FREDDY", fred); fred.Delete(3, 3); EXPECT_EQ("FRE", fred); - fred.Concat("D", 1); + fred.ConcatInPlace(1, "D"); EXPECT_EQ("FRED", fred); CFX_ByteString copy = fred; - fred.Concat("DY", 2); + fred.ConcatInPlace(2, "DY"); EXPECT_EQ("FREDDY", fred); EXPECT_EQ("FRED", copy); // Test invalid arguments. copy = fred; - fred.Concat("freddy", -6); + fred.ConcatInPlace(-6, "freddy"); CFX_ByteString not_aliased("xxxxxx"); EXPECT_EQ("FREDDY", fred); EXPECT_EQ("xxxxxx", not_aliased); |