diff options
| author | tsepez <tsepez@chromium.org> | 2016-12-07 09:21:17 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-12-07 09:21:18 -0800 |
| commit | 833619b4441915c7c55085d44b3221eaef0d9800 (patch) | |
| tree | 68bf76e83078223ba03f490c2c13f484e40154d4 /core/fxcrt/fx_basic_buffer.cpp | |
| parent | 8f875507a986d10335e40a5f7c1679aff9770d0a (diff) | |
| download | pdfium-833619b4441915c7c55085d44b3221eaef0d9800.tar.xz | |
Refcount all the IFX_ stream classes all the time.
We can remove a lot of "bOwnsStream" logic in the process.
Always pass these by const reference, in case the called method
wants to hang on to the stream (one exception is where we stick
a raw pointer into a void* slot in a context from another layer).
Review-Url: https://codereview.chromium.org/2451493002
Diffstat (limited to 'core/fxcrt/fx_basic_buffer.cpp')
| -rw-r--r-- | core/fxcrt/fx_basic_buffer.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/core/fxcrt/fx_basic_buffer.cpp b/core/fxcrt/fx_basic_buffer.cpp index 8466e88c56..e6d05528ae 100644 --- a/core/fxcrt/fx_basic_buffer.cpp +++ b/core/fxcrt/fx_basic_buffer.cpp @@ -234,7 +234,7 @@ CFX_FileBufferArchive::~CFX_FileBufferArchive() {} void CFX_FileBufferArchive::Clear() { m_Length = 0; m_pBuffer.reset(); - m_pFile = nullptr; + m_pFile.Reset(); } bool CFX_FileBufferArchive::Flush() { @@ -285,7 +285,8 @@ int32_t CFX_FileBufferArchive::AppendString(const CFX_ByteStringC& lpsz) { return AppendBlock(lpsz.raw_str(), lpsz.GetLength()); } -void CFX_FileBufferArchive::AttachFile(IFX_WriteStream* pFile) { +void CFX_FileBufferArchive::AttachFile( + const CFX_RetainPtr<IFX_WriteStream>& pFile) { ASSERT(pFile); m_pFile = pFile; } |