diff options
| author | tsepez <tsepez@chromium.org> | 2016-05-12 15:52:14 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-05-12 15:52:14 -0700 |
| commit | 28c7844c1ef5ea0c8727b890e9ff56b593119a00 (patch) | |
| tree | a96e31bbff3c221a0030e3a8a6501a5f81379d0f /core/fxcrt/fx_basic_gcc.cpp | |
| parent | ade9465067098d9f94a13f61741cebf4bb8aac47 (diff) | |
| download | pdfium-28c7844c1ef5ea0c8727b890e9ff56b593119a00.tar.xz | |
Add CFX_ByteStringC::CharAt() to avoid c_str() and casts.
Most of the time, we want to operate on chars as if they
were unsigned, but there are a few places where we need
the default (questionably signed) values. Consolidate
the casting in a single place rather than forcing callers
to get a char* ptr.
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1972053003
Diffstat (limited to 'core/fxcrt/fx_basic_gcc.cpp')
| -rw-r--r-- | core/fxcrt/fx_basic_gcc.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/core/fxcrt/fx_basic_gcc.cpp b/core/fxcrt/fx_basic_gcc.cpp index ddbdcd5881..a55a486293 100644 --- a/core/fxcrt/fx_basic_gcc.cpp +++ b/core/fxcrt/fx_basic_gcc.cpp @@ -226,9 +226,8 @@ int FXSYS_WideCharToMultiByte(uint32_t codepage, int len = 0; for (int i = 0; i < wlen; i++) { if (wstr[i] < 0x100) { - if (buf && len < buflen) { - buf[len] = (FX_CHAR)wstr[i]; - } + if (buf && len < buflen) + buf[len] = static_cast<FX_CHAR>(wstr[i]); len++; } } |