Add short-cut in CFX_{Byte,Wide}String::Operator<()

Strings are never less than themselves, and this will occur given
the shared CoW nature of these strings.

Review-Url: https://codereview.chromium.org/2347433004

1 files changed, 9 insertions, 0 deletions

diff --git a/core/fxcrt/fx_basic_wstring.cpp b/core/fxcrt/fx_basic_wstring.cpp
index 88fc588947..29e915f30c 100644
--- a/core/fxcrt/fx_basic_wstring.cpp
+++ b/core/fxcrt/fx_basic_wstring.cpp
@@ -194,6 +194,15 @@ bool CFX_WideString::operator==(const CFX_WideString& other) const {
                  m_pData->m_nDataLength) == 0;
 }
 
+bool CFX_WideString::operator<(const CFX_WideString& str) const {
+  if (m_pData == str.m_pData)
+    return false;
+
+  int result =
+      wmemcmp(c_str(), str.c_str(), std::min(GetLength(), str.GetLength()));
+  return result < 0 || (result == 0 && GetLength() < str.GetLength());
+}
+
 void CFX_WideString::AssignCopy(const FX_WCHAR* pSrcData, FX_STRSIZE nSrcLen) {
   AllocBeforeWrite(nSrcLen);
   m_pData->CopyContents(pSrcData, nSrcLen);