diff options
author | tsepez <tsepez@chromium.org> | 2016-04-11 10:56:00 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-04-11 10:56:00 -0700 |
commit | 184b82553000a41fd0c90be56fa2f1c1503e2e9e (patch) | |
tree | 568f3877f8f51cc80e8aacb355ba07674e673e9c /core/fxcrt/fx_basic_wstring_unittest.cpp | |
parent | f3209c1fe0fdea79bf2f4e2b6f77ea4ef5db1ad2 (diff) | |
download | pdfium-184b82553000a41fd0c90be56fa2f1c1503e2e9e.tar.xz |
Avoid copying in TrimRight() and TrimLeft() if possible.
Make Byte and Wide code identical while at it.
Review URL: https://codereview.chromium.org/1877553002
Diffstat (limited to 'core/fxcrt/fx_basic_wstring_unittest.cpp')
-rw-r--r-- | core/fxcrt/fx_basic_wstring_unittest.cpp | 62 |
1 files changed, 62 insertions, 0 deletions
diff --git a/core/fxcrt/fx_basic_wstring_unittest.cpp b/core/fxcrt/fx_basic_wstring_unittest.cpp index cfc190f72a..bc38141a95 100644 --- a/core/fxcrt/fx_basic_wstring_unittest.cpp +++ b/core/fxcrt/fx_basic_wstring_unittest.cpp @@ -472,6 +472,37 @@ TEST(fxcrt, WideStringTrimRight) { EXPECT_EQ(L"", empty); } +TEST(fxcrt, WideStringTrimRightCopies) { + { + // With a single reference, no copy takes place. + CFX_WideString fred(L" FRED "); + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimRight(); + EXPECT_EQ(L" FRED", fred); + EXPECT_EQ(old_buffer, fred.c_str()); + } + { + // With multiple references, we must copy. + CFX_WideString fred(L" FRED "); + CFX_WideString other_fred = fred; + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimRight(); + EXPECT_EQ(L" FRED", fred); + EXPECT_EQ(L" FRED ", other_fred); + EXPECT_NE(old_buffer, fred.c_str()); + } + { + // With multiple references, but no modifications, no copy. + CFX_WideString fred(L"FRED"); + CFX_WideString other_fred = fred; + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimRight(); + EXPECT_EQ(L"FRED", fred); + EXPECT_EQ(L"FRED", other_fred); + EXPECT_EQ(old_buffer, fred.c_str()); + } +} + TEST(fxcrt, WideStringTrimLeft) { CFX_WideString fred(L" FRED "); fred.TrimLeft(); @@ -500,6 +531,37 @@ TEST(fxcrt, WideStringTrimLeft) { EXPECT_EQ(L"", empty); } +TEST(fxcrt, WideStringTrimLeftCopies) { + { + // With a single reference, no copy takes place. + CFX_WideString fred(L" FRED "); + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimLeft(); + EXPECT_EQ(L"FRED ", fred); + EXPECT_EQ(old_buffer, fred.c_str()); + } + { + // With multiple references, we must copy. + CFX_WideString fred(L" FRED "); + CFX_WideString other_fred = fred; + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimLeft(); + EXPECT_EQ(L"FRED ", fred); + EXPECT_EQ(L" FRED ", other_fred); + EXPECT_NE(old_buffer, fred.c_str()); + } + { + // With multiple references, but no modifications, no copy. + CFX_WideString fred(L"FRED"); + CFX_WideString other_fred = fred; + const FX_WCHAR* old_buffer = fred.c_str(); + fred.TrimLeft(); + EXPECT_EQ(L"FRED", fred); + EXPECT_EQ(L"FRED", other_fred); + EXPECT_EQ(old_buffer, fred.c_str()); + } +} + TEST(fxcrt, WideStringUTF16LE_Encode) { struct UTF16LEEncodeCase { CFX_WideString ws; |