diff options
| author | tsepez <tsepez@chromium.org> | 2016-04-06 16:48:26 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-04-06 16:48:26 -0700 |
| commit | 46bf0331229a7b7fe73cbe111550f5dd467b184a (patch) | |
| tree | 4b99e9337e0c58c96bbf325e960401e23dff34ce /core/fxcrt/fx_basic_wstring_unittest.cpp | |
| parent | 6334af71040b6148e9001aad4bd134a6c6c14a8d (diff) | |
| download | pdfium-46bf0331229a7b7fe73cbe111550f5dd467b184a.tar.xz | |
Make wide strings use StringData template
Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp. The way to review
this patch is to diff those two files against each other.
They are beginning to converge.
Re-ordered some parameters in Concat() so that the string
comes before its length. It feels wrong otherwise.
Review URL: https://codereview.chromium.org/1846793002
Diffstat (limited to 'core/fxcrt/fx_basic_wstring_unittest.cpp')
| -rw-r--r-- | core/fxcrt/fx_basic_wstring_unittest.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/core/fxcrt/fx_basic_wstring_unittest.cpp b/core/fxcrt/fx_basic_wstring_unittest.cpp index 8f0084619d..cfc190f72a 100644 --- a/core/fxcrt/fx_basic_wstring_unittest.cpp +++ b/core/fxcrt/fx_basic_wstring_unittest.cpp @@ -251,26 +251,26 @@ TEST(fxcrt, WideStringOperatorNE) { TEST(fxcrt, WideStringConcatInPlace) { CFX_WideString fred; - fred.ConcatInPlace(4, L"FRED"); + fred.Concat(L"FRED", 4); EXPECT_EQ(L"FRED", fred); - fred.ConcatInPlace(2, L"DY"); + fred.Concat(L"DY", 2); EXPECT_EQ(L"FREDDY", fred); fred.Delete(3, 3); EXPECT_EQ(L"FRE", fred); - fred.ConcatInPlace(1, L"D"); + fred.Concat(L"D", 1); EXPECT_EQ(L"FRED", fred); CFX_WideString copy = fred; - fred.ConcatInPlace(2, L"DY"); + fred.Concat(L"DY", 2); EXPECT_EQ(L"FREDDY", fred); EXPECT_EQ(L"FRED", copy); // Test invalid arguments. copy = fred; - fred.ConcatInPlace(-6, L"freddy"); + fred.Concat(L"freddy", -6); CFX_WideString not_aliased(L"xxxxxx"); EXPECT_EQ(L"FREDDY", fred); EXPECT_EQ(L"xxxxxx", not_aliased); |