diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-09-13 17:41:52 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-09-13 17:41:52 +0000 |
| commit | a5d7ad3aa8feb08a14b5cca173d673054c1ade23 (patch) | |
| tree | 259f0c17f5b7a2e09f80948f8b5cc8a04fdb7874 /core/fxcrt/fx_string.h | |
| parent | aebace3bd14eaf72d43f63d90700cd1b0fa049ca (diff) | |
| download | pdfium-a5d7ad3aa8feb08a14b5cca173d673054c1ade23.tar.xz | |
Introduce FX_Number class as a replacement for FX_atonum().
The issue with FX_atonum() is that it doesn't return any information
about whether it range-checked its integer values as a signed or
unsigned type, even though it knows this as part of its processing.
Rather than adding another out parameter to that function, create
a class to hold all this information together.
This is the first place things went astray while diagnosing
bug 882959, in that a large positive value was cast to float as a
negative value. Unfortunately, this doesn't affect the related bug,
but is a step in the right direction.
Change-Id: I0977ec8fccf85e2632a962507bdd30a1cbe6d33c
Reviewed-on: https://pdfium-review.googlesource.com/42353
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt/fx_string.h')
| -rw-r--r-- | core/fxcrt/fx_string.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/core/fxcrt/fx_string.h b/core/fxcrt/fx_string.h index 2cf823738a..670aa4d4b7 100644 --- a/core/fxcrt/fx_string.h +++ b/core/fxcrt/fx_string.h @@ -7,6 +7,8 @@ #ifndef CORE_FXCRT_FX_STRING_H_ #define CORE_FXCRT_FX_STRING_H_ +#include <stdint.h> + #include "core/fxcrt/bytestring.h" #include "core/fxcrt/widestring.h" @@ -19,7 +21,6 @@ WideString FX_UTF8Decode(const ByteStringView& bsStr); float FX_atof(const ByteStringView& str); float FX_atof(const WideStringView& wsStr); -bool FX_atonum(const ByteStringView& str, void* pData); size_t FX_ftoa(float f, char* buf); #endif // CORE_FXCRT_FX_STRING_H_ |