diff options
author | Tom Sepez <tsepez@chromium.org> | 2017-04-17 13:08:36 -0700 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-17 20:51:44 +0000 |
commit | c329d59b16b89f3533f9d309ed297938af865ae0 (patch) | |
tree | 987d3c29056bc074185a2aa3c5963b8589139f81 /core/fxcrt/ifx_locale.h | |
parent | e190e7ce1e03ac536ecf825550482b84f7a3dfaa (diff) | |
download | pdfium-c329d59b16b89f3533f9d309ed297938af865ae0.tar.xz |
Fix buffer management issues in CFX_SAXReader.
Re-write to use std::vectors rather than self-managed buffers.
Includes test case that breaks before patch.
Formerly, we had two independent buffers whose position were
tracked by the same variable, assuming that only one was
being written to at a given time. This is a bad idea because
it's easy to forget to zero the index when switching buffers,
and start indexing into one using previously computed offsets
from the other.
Additionally, there were cases where the location of a partial
entity wasn't discarded when switching states thus clearing the
buffer tracking said entity.
Bug: 711459
Change-Id: I008f69517d4319a5fe8abda8d54c5b9975551697
Reviewed-on: https://pdfium-review.googlesource.com/4230
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt/ifx_locale.h')
0 files changed, 0 insertions, 0 deletions