diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-11-30 15:17:41 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-11-30 15:17:41 +0000 |
| commit | 56569acb6daa4d487a3d3eccce5784028873651c (patch) | |
| tree | de9fc0177c2e332f55d8ad010095bdeded19e8e7 /core/fxcrt/retain_ptr.h | |
| parent | e053e0fd169a62ce36b33e37b8ed6a1d29a77630 (diff) | |
| download | pdfium-56569acb6daa4d487a3d3eccce5784028873651c.tar.xz | |
Run clang-tidy modernize-use-equals-{delete,default} on //third_party/pdfium
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up
with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
Bug: chromium:778959, chromium:778957
Change-Id: I23e60d3d6c8bc9e8574d425710a0441cb5510d6b
Reviewed-on: https://pdfium-review.googlesource.com/19970
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fxcrt/retain_ptr.h')
| -rw-r--r-- | core/fxcrt/retain_ptr.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fxcrt/retain_ptr.h b/core/fxcrt/retain_ptr.h index 481bfbba56..e14b1ef5dc 100644 --- a/core/fxcrt/retain_ptr.h +++ b/core/fxcrt/retain_ptr.h @@ -28,7 +28,7 @@ class RetainPtr { m_pObj->Retain(); } - RetainPtr() {} + RetainPtr() = default; RetainPtr(const RetainPtr& that) : RetainPtr(that.Get()) {} RetainPtr(RetainPtr&& that) noexcept { Swap(that); } @@ -89,7 +89,7 @@ class Retainable { bool HasOneRef() const { return m_nRefCount == 1; } protected: - virtual ~Retainable() {} + virtual ~Retainable() = default; private: template <typename U> |