diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-08 22:20:29 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-08 22:20:29 +0000 |
| commit | f765805983d157e9a21d7202ba49148f24d226f3 (patch) | |
| tree | afae705a3a6c1fe55028cdebc5772ac244c7e762 /core/fxcrt/widestring.h | |
| parent | 4b17aea63fede24925cd7579c27f55298e5e9937 (diff) | |
| download | pdfium-f765805983d157e9a21d7202ba49148f24d226f3.tar.xz | |
Remove unused codepage from WideString::GetWideString().
Consolidate code into sole caller, which always retrieves a string
from the "default ANSI code page". Add unit test for this code path.
Fix sign extension bug giving bogus 0xffffff80 codepoint uncovered
by unit test on non-windows. Note windows result is different because
the system conversion routine does actually work.
Change-Id: I1c1246b203ee66e9ff0b6fccf97594788bcd0fca
Reviewed-on: https://pdfium-review.googlesource.com/39730
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt/widestring.h')
| -rw-r--r-- | core/fxcrt/widestring.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/core/fxcrt/widestring.h b/core/fxcrt/widestring.h index dc5dd23428..c51c74506b 100644 --- a/core/fxcrt/widestring.h +++ b/core/fxcrt/widestring.h @@ -61,9 +61,6 @@ class WideString { ~WideString(); static WideString FromLocal(const ByteStringView& str) WARN_UNUSED_RESULT; - static WideString FromCodePage(const ByteStringView& str, - uint16_t codepage) WARN_UNUSED_RESULT; - static WideString FromUTF8(const ByteStringView& str) WARN_UNUSED_RESULT; static WideString FromUTF16LE(const unsigned short* str, size_t len) WARN_UNUSED_RESULT; |