diff options
author | Lei Zhang <thestig@chromium.org> | 2018-10-18 21:04:03 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-18 21:04:03 +0000 |
commit | f58b6f62614357ef3a6f171a9f5c89d72981ac40 (patch) | |
tree | 4d30d9b9df8b831d24ae8a6d37b0ee4abce7bdb3 /core/fxcrt/xml/cfx_xmlelement.h | |
parent | 8e49f3fce1a56634284b254a0dc2d329da349355 (diff) | |
download | pdfium-f58b6f62614357ef3a6f171a9f5c89d72981ac40.tar.xz |
Remove some useless calls to the CFX_XMLNode ctor from subclasses.
Also fix some nits:
- Make member variable names consistent.
- Make member variables const.
- Make trivial getters return const-ref.
Change-Id: Ibd34c9bc58ec0eed3edfc3a8ea39b533a41cad73
Reviewed-on: https://pdfium-review.googlesource.com/c/44151
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlelement.h')
-rw-r--r-- | core/fxcrt/xml/cfx_xmlelement.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fxcrt/xml/cfx_xmlelement.h b/core/fxcrt/xml/cfx_xmlelement.h index 8a8720fa83..822f5ec132 100644 --- a/core/fxcrt/xml/cfx_xmlelement.h +++ b/core/fxcrt/xml/cfx_xmlelement.h @@ -24,7 +24,7 @@ class CFX_XMLElement final : public CFX_XMLNode { CFX_XMLNode* Clone(CFX_XMLDocument* doc) override; void Save(const RetainPtr<IFX_SeekableWriteStream>& pXMLStream) override; - WideString GetName() const { return name_; } + const WideString& GetName() const { return name_; } const std::map<WideString, WideString>& GetAttributes() const { return attrs_; @@ -48,7 +48,7 @@ class CFX_XMLElement final : public CFX_XMLNode { private: WideString AttributeToString(const WideString& name, const WideString& value); - WideString name_; + const WideString name_; std::map<WideString, WideString> attrs_; }; |