diff options
author | Lei Zhang <thestig@chromium.org> | 2018-10-18 21:04:03 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-18 21:04:03 +0000 |
commit | f58b6f62614357ef3a6f171a9f5c89d72981ac40 (patch) | |
tree | 4d30d9b9df8b831d24ae8a6d37b0ee4abce7bdb3 /core/fxcrt/xml/cfx_xmlinstruction.cpp | |
parent | 8e49f3fce1a56634284b254a0dc2d329da349355 (diff) | |
download | pdfium-f58b6f62614357ef3a6f171a9f5c89d72981ac40.tar.xz |
Remove some useless calls to the CFX_XMLNode ctor from subclasses.
Also fix some nits:
- Make member variable names consistent.
- Make member variables const.
- Make trivial getters return const-ref.
Change-Id: Ibd34c9bc58ec0eed3edfc3a8ea39b533a41cad73
Reviewed-on: https://pdfium-review.googlesource.com/c/44151
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlinstruction.cpp')
-rw-r--r-- | core/fxcrt/xml/cfx_xmlinstruction.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/fxcrt/xml/cfx_xmlinstruction.cpp b/core/fxcrt/xml/cfx_xmlinstruction.cpp index e0af2d1c95..fb534e3732 100644 --- a/core/fxcrt/xml/cfx_xmlinstruction.cpp +++ b/core/fxcrt/xml/cfx_xmlinstruction.cpp @@ -13,7 +13,7 @@ #include "core/fxcrt/xml/cfx_xmldocument.h" CFX_XMLInstruction::CFX_XMLInstruction(const WideString& wsTarget) - : CFX_XMLNode(), name_(wsTarget) {} + : name_(wsTarget) {} CFX_XMLInstruction::~CFX_XMLInstruction() = default; @@ -23,12 +23,12 @@ FX_XMLNODETYPE CFX_XMLInstruction::GetType() const { CFX_XMLNode* CFX_XMLInstruction::Clone(CFX_XMLDocument* doc) { auto* node = doc->CreateNode<CFX_XMLInstruction>(name_); - node->m_TargetData = m_TargetData; + node->target_data_ = target_data_; return node; } void CFX_XMLInstruction::AppendData(const WideString& wsData) { - m_TargetData.push_back(wsData); + target_data_.push_back(wsData); } bool CFX_XMLInstruction::IsOriginalXFAVersion() const { @@ -50,7 +50,7 @@ void CFX_XMLInstruction::Save( pXMLStream->WriteString(name_.UTF8Encode().AsStringView()); pXMLStream->WriteString(" "); - for (const WideString& target : m_TargetData) { + for (const WideString& target : target_data_) { pXMLStream->WriteString(target.UTF8Encode().AsStringView()); pXMLStream->WriteString(" "); } |