diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-02-13 21:09:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-13 21:09:32 +0000 |
| commit | 20eb52e66c565d36a78dc1399f04f7485ccf8fe6 (patch) | |
| tree | 679fc502d00ce8807295053b2e5e5ac79e14d43d /core/fxcrt/xml/cfx_xmlnode.h | |
| parent | 80bf582f00adeefae67ae432b74c3b0609e7845e (diff) | |
| download | pdfium-20eb52e66c565d36a78dc1399f04f7485ccf8fe6.tar.xz | |
Cleanup CFX_XMLNode and friendschromium/3347
This CL removes unused methods from CFX_XMLNode, adds an AppendChild to
handle the case of a -1 index to InsertChildNode, removes the
InsertChildNode return value which is unused and cleans up various other
things.
Change-Id: I3a022e4dc2afffa6893ad11014034dd7ed301f13
Reviewed-on: https://pdfium-review.googlesource.com/26510
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlnode.h')
| -rw-r--r-- | core/fxcrt/xml/cfx_xmlnode.h | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/core/fxcrt/xml/cfx_xmlnode.h b/core/fxcrt/xml/cfx_xmlnode.h index 278b3bf15a..dc3152f19a 100644 --- a/core/fxcrt/xml/cfx_xmlnode.h +++ b/core/fxcrt/xml/cfx_xmlnode.h @@ -30,16 +30,8 @@ class CFX_XMLNode { enum NodeItem { Root = 0, Parent, - FirstSibling, - PriorSibling, NextSibling, - LastSibling, - FirstNeighbor, - PriorNeighbor, - NextNeighbor, - LastNeighbor, FirstChild, - LastChild }; CFX_XMLNode(); @@ -48,21 +40,12 @@ class CFX_XMLNode { virtual FX_XMLNODETYPE GetType() const; virtual std::unique_ptr<CFX_XMLNode> Clone(); - int32_t CountChildNodes() const; - CFX_XMLNode* GetChildNode(int32_t index) const; - int32_t GetChildNodeIndex(CFX_XMLNode* pNode) const; - int32_t InsertChildNode(CFX_XMLNode* pNode, int32_t index = -1); + void AppendChild(CFX_XMLNode* pNode); + void InsertChildNode(CFX_XMLNode* pNode, int32_t index); void RemoveChildNode(CFX_XMLNode* pNode); void DeleteChildren(); - CFX_XMLNode* GetPath(const wchar_t* pPath, - int32_t iLength = -1, - bool bQualifiedName = true) const; - - int32_t GetNodeLevel() const; CFX_XMLNode* GetNodeItem(CFX_XMLNode::NodeItem eItem) const; - bool InsertNodeItem(CFX_XMLNode::NodeItem eItem, CFX_XMLNode* pNode); - CFX_XMLNode* RemoveNodeItem(CFX_XMLNode::NodeItem eItem); void SaveXMLNode(const RetainPtr<CFX_SeekableStreamProxy>& pXMLStream); |