summaryrefslogtreecommitdiff
path: root/core/fxcrt/xml/cfx_xmlparser.h
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2018-04-24 15:25:31 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-04-24 15:25:31 +0000
commit90e03b9b3f459e8812301b58ec0952b136f23a53 (patch)
tree071aa9ccb988c52a432bb83e47149e75af8ff78e /core/fxcrt/xml/cfx_xmlparser.h
parent2dca1cbf595618e06547a2c464d82c47b6acace6 (diff)
downloadpdfium-90e03b9b3f459e8812301b58ec0952b136f23a53.tar.xz
Remove duplicate data extraction from CFX_XMLParser
The methods to get a piece of data from the text buffer are all identical. This CL collapses them all into a single GetTextData method. Change-Id: Ibd2ace9023a3707505c4c80c6aeb01af666445d9 Reviewed-on: https://pdfium-review.googlesource.com/31273 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlparser.h')
-rw-r--r--core/fxcrt/xml/cfx_xmlparser.h17
1 files changed, 1 insertions, 16 deletions
diff --git a/core/fxcrt/xml/cfx_xmlparser.h b/core/fxcrt/xml/cfx_xmlparser.h
index 03f649c933..503852753f 100644
--- a/core/fxcrt/xml/cfx_xmlparser.h
+++ b/core/fxcrt/xml/cfx_xmlparser.h
@@ -50,22 +50,7 @@ class CFX_XMLParser {
protected:
FX_XmlSyntaxResult DoSyntaxParse();
-
- WideString GetTagName() const {
- return m_BlockBuffer.GetTextData(0, m_iTextDataLength);
- }
-
- WideString GetAttributeName() const {
- return m_BlockBuffer.GetTextData(0, m_iTextDataLength);
- }
-
- WideString GetAttributeValue() const {
- return m_BlockBuffer.GetTextData(0, m_iTextDataLength);
- }
-
- WideString GetTextData() const {
- return m_BlockBuffer.GetTextData(0, m_iTextDataLength);
- }
+ WideString GetTextData() const;
private:
enum class FDE_XmlSyntaxState {