diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-04-20 14:31:18 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-20 22:44:39 +0000 |
| commit | aeee187c927c07f47a9e5886a417dcc58badefb6 (patch) | |
| tree | 270351e970de6ac9f6530ca9c7448dc7b8c499e2 /core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp | |
| parent | c16ab75eb98733c857723f9c2947c77a56b2bb02 (diff) | |
| download | pdfium-aeee187c927c07f47a9e5886a417dcc58badefb6.tar.xz | |
Remove hand-written bsearch from cfx_xmlsyntaxparser.cppchromium/3077
Convert IsXMLNameChar() to static method for easier testing
without namespace pollution.
Change-Id: I004557e74fde94d3582b0a2326e5e68b907b9690
Reviewed-on: https://pdfium-review.googlesource.com/4397
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp')
| -rw-r--r-- | core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp b/core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp index 60c0d34655..09d4fea2d2 100644 --- a/core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp +++ b/core/fxcrt/xml/cfx_xmlsyntaxparser_unittest.cpp @@ -525,3 +525,20 @@ TEST_F(CFX_XMLSyntaxParserTest, EntityOverflowDecimal) { ASSERT_EQ(FX_XmlSyntaxResult::EndOfString, parser.DoSyntaxParse()); } + +TEST_F(CFX_XMLSyntaxParserTest, IsXMLNameChar) { + EXPECT_FALSE(CFX_XMLSyntaxParser::IsXMLNameChar(L'-', true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(L'-', false)); + + EXPECT_FALSE(CFX_XMLSyntaxParser::IsXMLNameChar(0x2069, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0x2070, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0x2073, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0x218F, true)); + EXPECT_FALSE(CFX_XMLSyntaxParser::IsXMLNameChar(0x2190, true)); + + EXPECT_FALSE(CFX_XMLSyntaxParser::IsXMLNameChar(0xFDEF, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0xFDF0, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0xFDF1, true)); + EXPECT_TRUE(CFX_XMLSyntaxParser::IsXMLNameChar(0xFFFD, true)); + EXPECT_FALSE(CFX_XMLSyntaxParser::IsXMLNameChar(0xFFFE, true)); +} |