diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-10-18 21:04:03 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-18 21:04:03 +0000 |
| commit | f58b6f62614357ef3a6f171a9f5c89d72981ac40 (patch) | |
| tree | 4d30d9b9df8b831d24ae8a6d37b0ee4abce7bdb3 /core/fxcrt/xml/cfx_xmltext.h | |
| parent | 8e49f3fce1a56634284b254a0dc2d329da349355 (diff) | |
| download | pdfium-f58b6f62614357ef3a6f171a9f5c89d72981ac40.tar.xz | |
Remove some useless calls to the CFX_XMLNode ctor from subclasses.
Also fix some nits:
- Make member variable names consistent.
- Make member variables const.
- Make trivial getters return const-ref.
Change-Id: Ibd34c9bc58ec0eed3edfc3a8ea39b533a41cad73
Reviewed-on: https://pdfium-review.googlesource.com/c/44151
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmltext.h')
| -rw-r--r-- | core/fxcrt/xml/cfx_xmltext.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/core/fxcrt/xml/cfx_xmltext.h b/core/fxcrt/xml/cfx_xmltext.h index 3e15c5ce9a..f2c7c88d72 100644 --- a/core/fxcrt/xml/cfx_xmltext.h +++ b/core/fxcrt/xml/cfx_xmltext.h @@ -22,11 +22,11 @@ class CFX_XMLText : public CFX_XMLNode { CFX_XMLNode* Clone(CFX_XMLDocument* doc) override; void Save(const RetainPtr<IFX_SeekableWriteStream>& pXMLStream) override; - WideString GetText() const { return m_wsText; } - void SetText(const WideString& wsText) { m_wsText = wsText; } + const WideString& GetText() const { return text_; } + void SetText(const WideString& wsText) { text_ = wsText; } private: - WideString m_wsText; + WideString text_; }; inline bool IsXMLText(const CFX_XMLNode* pNode) { |