diff options
| author | Nico Weber <thakis@chromium.org> | 2018-02-10 00:51:00 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-10 00:51:00 +0000 |
| commit | f6ecadb7aea68fb322bfa1dfce703a24cbd1e395 (patch) | |
| tree | 7ebb4e1f6dcdd4771096920a8383f8b4bd37f80e /core/fxcrt/xml | |
| parent | 257900b6dae0fe8d82d48ecc91d92e5dbb3a28bf (diff) | |
| download | pdfium-f6ecadb7aea68fb322bfa1dfce703a24cbd1e395.tar.xz | |
Renable -Wimplicit-fallthrough for PDFium.
Didn't find any bugs, but also doesn't require much boilerplate.
Bug: TODO
Change-Id: I5f30183c55216f1333c79fcb46476d281720873e
Reviewed-on: https://pdfium-review.googlesource.com/26210
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Diffstat (limited to 'core/fxcrt/xml')
| -rw-r--r-- | core/fxcrt/xml/cxml_parser.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/core/fxcrt/xml/cxml_parser.cpp b/core/fxcrt/xml/cxml_parser.cpp index ae5fd6d0fc..64bb0ec530 100644 --- a/core/fxcrt/xml/cxml_parser.cpp +++ b/core/fxcrt/xml/cxml_parser.cpp @@ -14,6 +14,7 @@ #include "core/fxcrt/cfx_utf8decoder.h" #include "core/fxcrt/cfx_widetextbuf.h" #include "core/fxcrt/fx_extension.h" +#include "core/fxcrt/fx_fallthrough.h" #include "core/fxcrt/xml/cxml_content.h" #include "core/fxcrt/xml/cxml_element.h" #include "core/fxcrt/xml/cxml_parser.h" @@ -200,6 +201,7 @@ uint32_t CXML_Parser::GetCharRef() { break; } iState = 1; + FX_FALLTHROUGH; case 1: m_dwIndex++; if (ch == ';') { @@ -226,6 +228,7 @@ uint32_t CXML_Parser::GetCharRef() { break; } iState = 3; + FX_FALLTHROUGH; case 3: m_dwIndex++; if (ch == ';') { |